Attachment 105819 Details for Bug 80759 – [untested] Enable Stats interface by default; disallow non-root use on system bus

[patch] [untested] Enable Stats interface by default; disallow non-root use on system bus

0001-Enable-Stats-interface-by-default-disallow-non-root-.patch (text/plain), 2.25 KB, created by Simon McVittie on 2014-09-05 17:55:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2014-09-05 17:55:50 UTC

Size: 2.25 KB

patch

obsolete

>From 924823e3cbf7cb7298d8363fbd87b47ffc10bfb0 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Fri, 5 Sep 2014 15:15:14 +0100
>Subject: [PATCH] Enable Stats interface by default; disallow non-root use on
> system bus
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=80759
>---
> bus/system.conf.in | 15 ++++++++++++++-
> configure.ac       |  6 +++---
> 2 files changed, 17 insertions(+), 4 deletions(-)
>
>diff --git a/bus/system.conf.in b/bus/system.conf.in
>index 92f4cc4..d3ac6b1 100644
>--- a/bus/system.conf.in
>+++ b/bus/system.conf.in
>@@ -63,11 +63,24 @@
>     <allow receive_type="signal"/>
> 
>     
>-    <allow send_destination="org.freedesktop.DBus"/>
>+    <allow send_destination="org.freedesktop.DBus"
>+           send_interface="org.freedesktop.DBus" />
>+    <allow send_destination="org.freedesktop.DBus"
>+           send_interface="org.freedesktop.DBus.Introspection"/>
>     
>     <deny send_destination="org.freedesktop.DBus"
>           send_interface="org.freedesktop.DBus"
>           send_member="UpdateActivationEnvironment"/>
>+    <deny send_destination="org.freedesktop.DBus"
>+          send_interface="org.freedesktop.DBus.Debug.Stats"/>
>+  </policy>
>+
>+  
>+  <policy user="root">
>+    <allow send_destination="org.freedesktop.DBus"
>+           send_interface="org.freedesktop.DBus.Debug.Stats"/>
>   </policy>
> 
>   <!-- Config files are placed here that among other things, punch 
>diff --git a/configure.ac b/configure.ac
>index cbaf874..09a72f6 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -1740,9 +1740,9 @@ AH_VERBATIM(_DARWIN_ENVIRON,
> ])
> 
> AC_ARG_ENABLE([stats],
>-  [AS_HELP_STRING([--enable-stats],
>-    [enable bus daemon usage statistics])],
>-  [], [enable_stats=no])
>+  [AS_HELP_STRING([--disable-stats],
>+    [disable bus daemon usage statistics])],
>+  [], [enable_stats=yes])
> if test "x$enable_stats" = xyes; then
>   AC_DEFINE([DBUS_ENABLE_STATS], [1],
>     [Define to enable bus daemon usage statistics])
>-- 
>2.1.0
>

Actions: View | Splinter Review

Attachments on bug 80759: 102077 | 102078 | 102079 | 102080 | 105819 | 106917 | 106918 | 107201

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.