Attachment 107489 Details for Bug 83640 – Possible fix

[patch] Possible fix

0001-drm-i915-properly-reenable-gen8-pipe-IRQs.patch (text/plain), 1.42 KB, created by Paulo Zanoni on 2014-10-07 12:34:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paulo Zanoni

Created: 2014-10-07 12:34:09 UTC

Size: 1.42 KB

patch

obsolete

>From 6f5b43305eadee4fc4dee4b2ad1b9bd3b12c1fc6 Mon Sep 17 00:00:00 2001
>From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>Date: Tue, 7 Oct 2014 09:31:07 -0300
>Subject: [PATCH] drm/i915: properly reenable gen8 pipe IRQs
>
>We were missing the pipe B/C vblank bits! This should fix a bunch of
>IGT tests.
>
>There are a few more things we could improve on this code, but this
>should be the minimal fix to unblock us.
>
>Bugzilla:https://bugs.freedesktop.org/show_bug.cgi?id=83640
>Testcase: igt/*
>Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
>---
> drivers/gpu/drm/i915/i915_irq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
>index b12c4c4..3bbdb9c 100644
>--- a/drivers/gpu/drm/i915/i915_irq.c
>+++ b/drivers/gpu/drm/i915/i915_irq.c
>@@ -3166,11 +3166,13 @@ static void gen8_irq_reset(struct drm_device *dev)
> 
> void gen8_irq_power_well_post_enable(struct drm_i915_private *dev_priv)
> {
>+	uint32_t extra_iir = GEN8_PIPE_VBLANK | GEN8_PIPE_FIFO_UNDERRUN;
>+
> 	spin_lock_irq(&dev_priv->irq_lock);
> 	GEN8_IRQ_INIT_NDX(DE_PIPE, PIPE_B, dev_priv->de_irq_mask[PIPE_B],
>-			  ~dev_priv->de_irq_mask[PIPE_B]);
>+			  ~dev_priv->de_irq_mask[PIPE_B] | extra_iir);
> 	GEN8_IRQ_INIT_NDX(DE_PIPE, PIPE_C, dev_priv->de_irq_mask[PIPE_C],
>-			  ~dev_priv->de_irq_mask[PIPE_C]);
>+			  ~dev_priv->de_irq_mask[PIPE_C] | extra_iir);
> 	spin_unlock_irq(&dev_priv->irq_lock);
> }
> 
>-- 
>2.1.1
>

Actions: View | Splinter Review

Attachments on bug 83640: 105941 | 107489

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.