Attachment 110497 Details for Bug 86959 – drm/i915: Clean the request structure on alloc

[patch] drm/i915: Clean the request structure on alloc

0001-drm-i915-Clean-the-request-structure-on-alloc.patch (text/plain), 1.34 KB, created by Mika Kuoppala on 2014-12-05 17:50:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mika Kuoppala

Created: 2014-12-05 17:50:11 UTC

Size: 1.34 KB

patch

obsolete

>From a2a20f86b3b0c4c8ebb2dff46d72f733acb55764 Mon Sep 17 00:00:00 2001
>From: Mika Kuoppala <mika.kuoppala@intel.com>
>Date: Fri, 5 Dec 2014 19:42:01 +0200
>Subject: [PATCH] drm/i915: Clean the request structure on alloc
>
>Otherwise we might end up referencing uninitialized fields.
>This is apparent when we try to cleanup the preallocated request
>on ring reset, before any request has been submitted to the ring.
>The request->ctx is foobar and we end up freeing the foobarness.
>
>References: https://bugs.freedesktop.org/show_bug.cgi?id=86959
>References: https://bugs.freedesktop.org/show_bug.cgi?id=86962
>References: https://bugs.freedesktop.org/show_bug.cgi?id=86992
>Cc: John Harrison <John.C.Harrison@Intel.com>
>Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
>---
> drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
>index 79b4ca5..2c6c6f8 100644
>--- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>+++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>@@ -2030,7 +2030,7 @@ intel_ring_alloc_request(struct intel_engine_cs *ring)
> 	if (ring->outstanding_lazy_request)
> 		return 0;
> 
>-	request = kmalloc(sizeof(*request), GFP_KERNEL);
>+	request = kzalloc(sizeof(*request), GFP_KERNEL);
> 	if (request == NULL)
> 		return -ENOMEM;
> 
>-- 
>1.9.1
>

Actions: View | Splinter Review

Attachments on bug 86959: 110390 | 110497

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.