Attachment 113978 Details for Bug 89284 – Fix of 'warning: variable ‘..‘ set but not used [-Wunused-but-set-variable]'. (update)

[patch] Fix of 'warning: variable ‘..‘ set but not used [-Wunused-but-set-variable]'. (update)

0002-Fix-of-warning-variable-.-set-but-not-used-Wunused-but.txt (text/plain), 1.82 KB, created by Ralf Habacker on 2015-03-04 07:23:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralf Habacker

Created: 2015-03-04 07:23:52 UTC

Size: 1.82 KB

patch

obsolete

>From cbef5ae4d20e2e942b542333e2d1550c709e4a13 Mon Sep 17 00:00:00 2001
>From: Ralf Habacker <ralf.habacker@freenet.de>
>Date: Wed, 4 Mar 2015 08:19:59 +0100
>Subject: [PATCH 2/2] =?UTF-8?q?Fix=20of=20'warning:=20variable=20=E2=80=98?=
> =?UTF-8?q?..=E2=80=98=20set=20but=20not=20used=20[-Wunused-but-set-variab?=
> =?UTF-8?q?le]'.?=
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284
>---
> test/test-service.c     | 8 +++-----
> tools/dbus-launch-win.c | 6 +-----
> 2 files changed, 4 insertions(+), 10 deletions(-)
>
>diff --git a/test/test-service.c b/test/test-service.c
>index 7181fa3..c0bd2c6 100644
>--- a/test/test-service.c
>+++ b/test/test-service.c
>@@ -400,20 +400,18 @@ main (int    argc,
>   int result;
>   DBusConnection *connection;
>   const char *name;
>-  dbus_bool_t do_fork;
>-
>+#ifndef DBUS_WIN
>+  dbus_bool_t do_fork = FALSE;
>+#endif
>   if (argc != 3)
>     {
>       name = "org.freedesktop.DBus.TestSuiteEchoService";
>-      do_fork = FALSE;
>     }
>   else
>     {
>       name = argv[1];
> #ifndef DBUS_WIN
>       do_fork = strcmp (argv[2], "fork") == 0;
>-#else
>-      do_fork = FALSE;
> #endif
>     }
> 
>diff --git a/tools/dbus-launch-win.c b/tools/dbus-launch-win.c
>index d899010..1dfd095 100644
>--- a/tools/dbus-launch-win.c
>+++ b/tools/dbus-launch-win.c
>@@ -89,7 +89,7 @@ main (int argc, char **argv)
>   wchar_t *p;
>   wchar_t *daemon_name;
>   int result;
>-  int showConsole = 0;
>+
> #ifdef DBUS_WINCE
>   char *s = NULL;
> #else
>@@ -102,10 +102,6 @@ main (int argc, char **argv)
>   BOOL inherit = TRUE;
>   DWORD flags = 0;
> 
>-#ifdef AUTO_ACTIVATE_CONSOLE_WHEN_VERBOSE_MODE
>-  if (verbose)
>-      showConsole = 1; 
>-#endif
>   GetModuleFileNameW (NULL, dbusDaemonPath, DIM (dbusDaemonPath));
>   
>   daemon_name = WCSTRINGIFY(DBUS_DAEMON_NAME) L".exe";
>-- 
>1.8.4.5
>

Actions: View | Splinter Review

Attachments on bug 89284: 113763 | 113808 | 113814 | 113842 | 113946 | 113953 | 113956 | 113957 | 113958 | 113976 | 113977 | 113978 | 113980 | 113985 | 113987

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.