Attachment 119347 Details for Bug 92721 – Don't use _dbus_warn() for intentionally-skipped tests

[patch] Don't use _dbus_warn() for intentionally-skipped tests

0001-Don-t-use-_dbus_warn-for-intentionally-skipped-tests.patch (text/plain), 1.37 KB, created by Simon McVittie on 2015-11-02 14:47:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2015-11-02 14:47:25 UTC

Size: 1.37 KB

patch

obsolete

>From b4476f8cc0562d9f2ee8b0697f6791ef2b8afcf6 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 2 Nov 2015 14:35:57 +0000
>Subject: [PATCH] Don't use _dbus_warn() for intentionally-skipped tests
>
>The tests are run with _dbus_warn() fatal, so if a particular test is
>not applicable on the current platform, we shouldn't call it.
>
>Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92721
>---
> dbus/dbus-auth-script.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/dbus/dbus-auth-script.c b/dbus/dbus-auth-script.c
>index 7387220..60d3053 100644
>--- a/dbus/dbus-auth-script.c
>+++ b/dbus/dbus-auth-script.c
>@@ -339,7 +339,7 @@ _dbus_auth_script_run (const DBusString *filename)
>                                                "UNIX_ONLY"))
>         {
>           /* skip this file */
>-          _dbus_warn ("skipping unix only auth script\n");
>+          fprintf (stderr, "skipping unix only auth script\n");
>           retval = TRUE;
>           goto out;
>         }
>@@ -355,7 +355,7 @@ _dbus_auth_script_run (const DBusString *filename)
>                                                "WIN_ONLY"))
>         {
>           /* skip this file */
>-          _dbus_warn ("skipping windows only auth script\n");
>+          fprintf (stderr, "skipping windows only auth script\n");
>           retval = TRUE;
>           goto out;
>         }
>-- 
>2.6.2
>

Actions: View | Splinter Review

Attachments on bug 92721: 119290 | 119291 | 119292 | 119312 | 119313 | 119316 | 119317 | 119341 | 119344 | 119345 | 119346 | 119347 | 119352 | 119353 | 119355 | 119356 | 119357 | 119358 | 119361 | 119362 | 119419 | 119437 | 119438 | 119439 | 119478 | 119479 | 119488 | 119490 | 119491 | 119509 | 119510 | 119522 | 119523 | 119529 | 119530 | 119562 | 119575 | 119576 | 119649 | 119650 | 119651 | 119655 | 119689 | 119710 | 119711 | 119712 | 119713 | 119715 | 119716 | 119725 | 119737 | 119738 | 119739 | 119740 | 120084 | 120171 | 120186

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.