Attachment 131746 Details for Bug 101257 – [1/10] test/dbus-daemon: Fix some memory leaks

[patch] [1/10] test/dbus-daemon: Fix some memory leaks

0001-test-dbus-daemon-Fix-some-memory-leaks.patch (text/plain), 1.75 KB, created by Simon McVittie on 2017-06-06 21:56:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2017-06-06 21:56:28 UTC

Size: 1.75 KB

patch

obsolete

>From 143b795c3ffed985d2062fa62756aa735e18577e Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Fri, 2 Jun 2017 12:19:18 +0100
>Subject: [PATCH 01/10] test/dbus-daemon: Fix some memory leaks
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> test/dbus-daemon.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/test/dbus-daemon.c b/test/dbus-daemon.c
>index d0b44d72..9f9dd723 100644
>--- a/test/dbus-daemon.c
>+++ b/test/dbus-daemon.c
>@@ -370,6 +370,8 @@ test_no_reply (Fixture *f,
>   else
>     g_assert_cmpstr (f->e.message, ==,
>         "Message did not receive a reply (timeout by message bus)");
>+
>+  dbus_message_unref (reply);
> }
> 
> static void
>@@ -529,6 +531,9 @@ test_creds (Fixture *f,
> #ifdef G_OS_WIN32
>   g_assert (seen & SEEN_WINDOWS_SID);
> #endif
>+
>+  dbus_message_unref (m);
>+  dbus_pending_call_unref (pc);
> }
> 
> static void
>@@ -599,6 +604,9 @@ test_processid (Fixture *f,
>     {
>       g_error ("Unexpected error: %s: %s", error.name, error.message);
>     }
>+
>+  dbus_message_unref (m);
>+  dbus_pending_call_unref (pc);
> }
> 
> static void
>@@ -644,6 +652,8 @@ test_canonical_path_uae (Fixture *f,
>       DBUS_MESSAGE_TYPE_METHOD_RETURN);
> 
>   dbus_message_unref (m);
>+  dbus_pending_call_unref (pc);
>+  pc = NULL;
> 
>   /* Now try with the wrong object path */
>   m = dbus_message_new_method_call (DBUS_SERVICE_DBUS,
>@@ -684,6 +694,7 @@ test_canonical_path_uae (Fixture *f,
>   g_assert_cmpstr (dbus_message_get_signature (m), ==, "s");
> 
>   dbus_message_unref (m);
>+  dbus_pending_call_unref (pc);
> }
> 
> static void
>@@ -815,6 +826,7 @@ test_max_replies_per_connection (Fixture *f,
>         g_error ("OOM");
> 
>       dbus_message_unref (reply);
>+      dbus_message_unref (m);
>     }
> 
>   /* Wait for all 5 replies to come in. */
>-- 
>2.11.0
>

Actions: View | Splinter Review

Attachments on bug 101257: 131617 | 131618 | 131619 | 131669 | 131670 | 131671 | 131672 | 131673 | 131674 | 131675 | 131676 | 131746 | 131747 | 131748 | 131749 | 131750 | 131751 | 131752 | 131753 | 131754 | 131755 | 131774 | 131775 | 131776 | 131781 | 131782

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.