Attachment 132345 Details for Bug 101567 – spec: Do not promise match rules with eavesdrop='true' can be added

[patch] spec: Do not promise match rules with eavesdrop='true' can be added

0001-spec-Do-not-promise-match-rules-with-eavesdrop-true-.patch (text/plain), 2.05 KB, created by Simon McVittie on 2017-06-29 15:36:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2017-06-29 15:36:06 UTC

Size: 2.05 KB

patch

obsolete

>From 322aec3c0c2f38b596e8b26cb6ebea7ed55d6a2a Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Thu, 29 Jun 2017 16:31:46 +0100
>Subject: [PATCH 1/3] spec: Do not promise match rules with eavesdrop='true'
> can be added
>
>This is no longer true, and it seems less misleading to raise an
>error than to obey the letter of the spec by quietly ignoring calls
>from an inappropriate caller.
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> doc/dbus-specification.xml | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/doc/dbus-specification.xml b/doc/dbus-specification.xml
>index 5145581c..571f037d 100644
>--- a/doc/dbus-specification.xml
>+++ b/doc/dbus-specification.xml
>@@ -4371,9 +4371,7 @@
>         <para>
>           Clients may attempt to eavesdrop by adding match rules
>           (see <xref linkend="message-bus-routing-match-rules"/>) containing
>-          the <literal>eavesdrop='true'</literal> match. If the message bus'
>-          security policy does not allow eavesdropping, the match rule can
>-          still be added, but will not have any practical effect. For
>+          the <literal>eavesdrop='true'</literal> match. For
>           compatibility with older message bus implementations, if adding such
>           a match rule results in an error reply, the client may fall back to
>           adding the same rule with the <literal>eavesdrop</literal> match
>@@ -4624,9 +4622,6 @@
>                     delivered to their <literal>DESTINATION</literal>
>                     regardless of match rules, so this match does not
>                     affect normal delivery of unicast messages.
>-                    If the message bus has a security policy which forbids
>-                    eavesdropping, this match may still be used without error,
>-                    but will not have any practical effect.
>                     In older versions of D-Bus, this match was not allowed
>                     in match rules, and all match rules behaved as if
>                     <literal>eavesdrop='true'</literal> had been used.
>-- 
>2.13.2
>

Actions: View | Splinter Review

Attachments on bug 101567: 132159 | 132160 | 132164 | 132168 | 132345 | 132346 | 132347

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.