Attachment 136300 Details for Bug 103457 – [1/2] containers test: Don't assert that GetConnectionCredentials has Type, Name

[patch] [1/2] containers test: Don't assert that GetConnectionCredentials has Type, Name

0001-containers-test-Don-t-assert-that-GetConnectionCrede.patch (text/plain), 1.52 KB, created by Simon McVittie on 2017-12-19 20:05:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2017-12-19 20:05:38 UTC

Size: 1.52 KB

patch

obsolete

>From 6556235d61cc619ea87b62802725bdc046119e3e Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Tue, 19 Dec 2017 20:00:18 +0000
>Subject: [PATCH 1/2] containers test: Don't assert that
> GetConnectionCredentials has Type, Name
>
>It isn't clear whether we want these in GetConnectionCredentials(),
>because if we later open up different-uid access to the container
>sockets, it raises questions of how strongly we can trust that
>information.
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> test/containers.c | 8 --------
> 1 file changed, 8 deletions(-)
>
>diff --git a/test/containers.c b/test/containers.c
>index b706bdd1..92e93ae6 100644
>--- a/test/containers.c
>+++ b/test/containers.c
>@@ -509,14 +509,6 @@ test_metadata (Fixture *f,
>                                         DBUS_INTERFACE_CONTAINERS1 ".Instance",
>                                         "&o", &path_from_query));
>   g_assert_cmpstr (path_from_query, ==, f->instance_path);
>-  g_assert_true (g_variant_dict_lookup (&dict,
>-                                        DBUS_INTERFACE_CONTAINERS1 ".Type",
>-                                        "&s", &type));
>-  g_assert_cmpstr (type, ==, "org.example.Springwatch");
>-  g_assert_true (g_variant_dict_lookup (&dict,
>-                                        DBUS_INTERFACE_CONTAINERS1 ".Name",
>-                                        "&s", &name));
>-  g_assert_cmpstr (name, ==, "");
>   g_variant_dict_clear (&dict);
>   g_clear_pointer (&asv, g_variant_unref);
>   g_clear_pointer (&tuple, g_variant_unref);
>-- 
>2.15.1
>

Actions: View | Splinter Review

Attachments on bug 103457: 136300 | 136301

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.