Attachment 140563 Details for Bug 107194 – [1] Assert that DBUS_SERVER_LISTEN_ADDRESS_ALREADY_USED does not set error

[patch] [1] Assert that DBUS_SERVER_LISTEN_ADDRESS_ALREADY_USED does not set error

0001-Assert-that-DBUS_SERVER_LISTEN_ADDRESS_ALREADY_USED-.patch (text/plain), 1.02 KB, created by Simon McVittie on 2018-07-11 17:34:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2018-07-11 17:34:06 UTC

Size: 1.02 KB

patch

obsolete

>From 820544f210b5485fac51285e9c02c2c8351cb005 Mon Sep 17 00:00:00 2001
>From: Simon McVittie <smcv@collabora.com>
>Date: Mon, 9 Jul 2018 17:06:22 +0100
>Subject: [PATCH 1/7] Assert that DBUS_SERVER_LISTEN_ADDRESS_ALREADY_USED does
> not set error
>
>The only place this is set in practice is in dbus-server-win.c, which
>does not set the error. If it did, dbus_server_listen() would leak it.
>
>Signed-off-by: Simon McVittie <smcv@collabora.com>
>---
> dbus/dbus-server.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/dbus/dbus-server.c b/dbus/dbus-server.c
>index d91df832..f26a8f7c 100644
>--- a/dbus/dbus-server.c
>+++ b/dbus/dbus-server.c
>@@ -595,6 +595,7 @@ dbus_server_listen (const char     *address,
>           else if (result == DBUS_SERVER_LISTEN_ADDRESS_ALREADY_USED)
>             {
>               _dbus_assert (server == NULL);
>+              _DBUS_ASSERT_ERROR_IS_CLEAR (&tmp_error);
>               dbus_set_error (error,
>                        DBUS_ERROR_ADDRESS_IN_USE,
>                        "Address '%s' already used",
>-- 
>2.18.0
>

Actions: View | Splinter Review

Attachments on bug 107194: 140563 | 140564 | 140565 | 140566 | 140567 | 140568 | 140569 | 140570 | 140571 | 140598 | 140599 | 140600 | 140601 | 140602 | 140603 | 140604 | 140605 | 140606 | 140607 | 140942 | 140943

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.