Attachment 18673 Details for Bug 17433 – Fix some signedness warnings in the dbus-marshal-basic tests.

[patch] Fix some signedness warnings in the dbus-marshal-basic tests.

0001-Fix-some-signedness-warnings-in-the-dbus-marshal-bas.patch (text/plain), 2.13 KB, created by Peter McCurdy on 2008-09-04 10:53:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter McCurdy

Created: 2008-09-04 10:53:35 UTC

Size: 2.13 KB

patch

obsolete

>From ea12f4b6924b4e7eb05d3edd87599144dbbcaace Mon Sep 17 00:00:00 2001
>From: Peter McCurdy <petermccurdy@alumni.uwaterloo.ca>
>Date: Sun, 31 Aug 2008 23:18:04 -0400
>Subject: [PATCH] Fix some signedness warnings in the dbus-marshal-basic tests.
>
>---
> dbus/dbus-marshal-basic.c |   12 +++++++-----
> 1 files changed, 7 insertions(+), 5 deletions(-)
>
>diff --git a/dbus/dbus-marshal-basic.c b/dbus/dbus-marshal-basic.c
>index 0a33ff1..365cf04 100644
>--- a/dbus/dbus-marshal-basic.c
>+++ b/dbus/dbus-marshal-basic.c
>@@ -1651,6 +1651,8 @@ _dbus_marshal_test (void)
>   unsigned char array1[5] = { 3, 4, 0, 1, 9 };
>   dbus_int16_t array2[3] = { 124, 457, 780 };
>   dbus_int32_t array4[3] = { 123, 456, 789 };
>+  dbus_uint16_t uarray2[3] = { 124, 457, 780 };
>+  dbus_uint32_t uarray4[3] = { 123, 456, 789 };
> #ifdef DBUS_HAVE_INT64
>   dbus_int64_t array8[3] = { DBUS_INT64_CONSTANT (0x123ffffffff),
>                              DBUS_INT64_CONSTANT (0x456ffffffff),
>@@ -1671,7 +1673,7 @@ _dbus_marshal_test (void)
>   dbus_uint32_t v_UINT32;
>   dbus_int64_t v_INT64;
>   dbus_uint64_t v_UINT64;
>-  unsigned char v_BYTE;
>+  char v_BYTE;
>   dbus_bool_t v_BOOLEAN;
>   const char *v_STRING;
>   const char *v_SIGNATURE;
>@@ -1751,13 +1753,13 @@ _dbus_marshal_test (void)
>   /* Arrays */
>   MARSHAL_TEST_FIXED_ARRAY (INT16, DBUS_BIG_ENDIAN, array2);
>   MARSHAL_TEST_FIXED_ARRAY (INT16, DBUS_LITTLE_ENDIAN, array2);
>-  MARSHAL_TEST_FIXED_ARRAY (UINT16, DBUS_BIG_ENDIAN, array2);
>-  MARSHAL_TEST_FIXED_ARRAY (UINT16, DBUS_LITTLE_ENDIAN, array2);
>+  MARSHAL_TEST_FIXED_ARRAY (UINT16, DBUS_BIG_ENDIAN, uarray2);
>+  MARSHAL_TEST_FIXED_ARRAY (UINT16, DBUS_LITTLE_ENDIAN, uarray2);
>   
>   MARSHAL_TEST_FIXED_ARRAY (INT32, DBUS_BIG_ENDIAN, array4);
>   MARSHAL_TEST_FIXED_ARRAY (INT32, DBUS_LITTLE_ENDIAN, array4);
>-  MARSHAL_TEST_FIXED_ARRAY (UINT32, DBUS_BIG_ENDIAN, array4);
>-  MARSHAL_TEST_FIXED_ARRAY (UINT32, DBUS_LITTLE_ENDIAN, array4);
>+  MARSHAL_TEST_FIXED_ARRAY (UINT32, DBUS_BIG_ENDIAN, uarray4);
>+  MARSHAL_TEST_FIXED_ARRAY (UINT32, DBUS_LITTLE_ENDIAN, uarray4);
> 
>   MARSHAL_TEST_FIXED_ARRAY (BYTE, DBUS_BIG_ENDIAN, array1);
>   MARSHAL_TEST_FIXED_ARRAY (BYTE, DBUS_LITTLE_ENDIAN, array1);
>-- 
>1.5.4.3
>

Actions: View | Splinter Review

Attachments on bug 17433: 18673 | 18674 | 18675 | 18676 | 18677

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.