Attachment 34981 Details for Bug 27623 – Silence unused-return-value warnings on recent glibc.

[patch] Silence unused-return-value warnings on recent glibc.

0001-Silence-unused-return-value-warnings-on-recent-glibc.patch (text/plain), 1.53 KB, created by Marcus Brinkmann on 2010-04-13 18:25:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcus Brinkmann

Created: 2010-04-13 18:25:09 UTC

Size: 1.53 KB

patch

obsolete

>From 41e8bb55cd34a72100f21c6448c868250ebb3092 Mon Sep 17 00:00:00 2001
>From: Marcus Brinkmann <marcus.brinkmann@ruhr-uni-bochum.de>
>Date: Wed, 14 Apr 2010 01:29:13 +0200
>Subject: [PATCH 1/5] Silence unused-return-value warnings on recent glibc.
>
>---
> dbus/dbus-spawn.c   |    2 +-
> tools/dbus-launch.c |    8 +++++---
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/dbus/dbus-spawn.c b/dbus/dbus-spawn.c
>index c3be1b7..9533e23 100644
>--- a/dbus/dbus-spawn.c
>+++ b/dbus/dbus-spawn.c
>@@ -1079,7 +1079,7 @@ babysit (pid_t grandchild_pid,
>       else if (pfds[1].revents & _DBUS_POLLIN)
>         {
>           char b;
>-          read (sigchld_pipe[READ_END], &b, 1);
>+          int res = read (sigchld_pipe[READ_END], &b, 1);
>           /* do waitpid check */
>           check_babysit_events (grandchild_pid, parent_pipe, 0);
>         }
>diff --git a/tools/dbus-launch.c b/tools/dbus-launch.c
>index ec4c9a5..552e701 100644
>--- a/tools/dbus-launch.c
>+++ b/tools/dbus-launch.c
>@@ -363,11 +363,13 @@ print_variables (const char *bus_address, pid_t bus_pid, long bus_wid,
> 		 int c_shell_syntax, int bourne_shell_syntax,
> 		 int binary_syntax)
> {
>+  int res;
>+
>   if (binary_syntax)
>     {
>-      write (1, bus_address, strlen (bus_address) + 1);
>-      write (1, &bus_pid, sizeof bus_pid);
>-      write (1, &bus_wid, sizeof bus_wid);
>+      res = write (1, bus_address, strlen (bus_address) + 1);
>+      res = write (1, &bus_pid, sizeof bus_pid);
>+      res = write (1, &bus_wid, sizeof bus_wid);
>       return;
>     }
>   else if (c_shell_syntax)
>-- 
>1.7.0.4
>

Actions: View | Splinter Review

Attachments on bug 27623: 34981

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.