Attachment 45384 Details for Bug 34870 – Check parsing (or otherwise) of path_namespace in match rules

[patch] Check parsing (or otherwise) of path_namespace in match rules

0003-Check-parsing-or-otherwise-of-path_namespace-in-matc.patch (text/plain), 1.31 KB, created by Simon McVittie on 2011-04-07 08:33:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2011-04-07 08:33:16 UTC

Size: 1.31 KB

patch

obsolete

>From 2dafaac83991078ed206ad359dda037e492e80df Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Thu, 7 Apr 2011 16:30:41 +0100
>Subject: [PATCH 3/4] Check parsing (or otherwise) of path_namespace in match rules
>
>---
> bus/signals.c |   18 ++++++++++++++++++
> 1 files changed, 18 insertions(+), 0 deletions(-)
>
>diff --git a/bus/signals.c b/bus/signals.c
>index d7bddca..4d34ca1 100644
>--- a/bus/signals.c
>+++ b/bus/signals.c
>@@ -2255,6 +2255,24 @@ test_parsing (void *data)
>   rule = check_parse (FALSE, "type='signal',type='method_call'");
>   _dbus_assert (rule == NULL);
> 
>+  rule = check_parse (TRUE, "path_namespace='/foo/bar'");
>+  if (rule != NULL)
>+    {
>+      _dbus_assert (rule->flags == BUS_MATCH_PATH_NAMESPACE);
>+      _dbus_assert (rule->path != NULL);
>+      _dbus_assert (strcmp (rule->path, "/foo/bar") == 0);
>+
>+      bus_match_rule_unref (rule);
>+    }
>+
>+  /* Almost a duplicate */
>+  rule = check_parse (FALSE, "path='/foo',path_namespace='/foo'");
>+  _dbus_assert (rule == NULL);
>+
>+  /* Trailing / was supported in the initial proposal, but now isn't */
>+  rule = check_parse (FALSE, "path_namespace='/foo/'");
>+  _dbus_assert (rule == NULL);
>+
>   /* Duplicates with the argN code */
>   rule = check_parse (FALSE, "arg0='foo',arg0='bar'");
>   _dbus_assert (rule == NULL);
>-- 
>1.7.4.1
>

Actions: View | Splinter Review

Attachments on bug 34870: 44235 | 45376 | 45377 | 45382 | 45384 | 45385

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.