Attachment 52211 Details for Bug 41653 – workaround: destroy rotation damage only when screen has a drawable

[patch] workaround: destroy rotation damage only when screen has a drawable

workaround-crash-on-close.patch (text/plain), 1.04 KB, created by Michal Suchanek on 2011-10-11 05:47:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michal Suchanek

Created: 2011-10-11 05:47:43 UTC

Size: 1.04 KB

patch

obsolete

>Index: xserver/hw/xfree86/modes/xf86Rotate.c
>===================================================================
>--- xserver.orig/hw/xfree86/modes/xf86Rotate.c	2011-10-11 13:24:11.000000000 +0200
>+++ xserver/hw/xfree86/modes/xf86Rotate.c	2011-10-11 14:31:32.000000000 +0200
>@@ -283,6 +283,7 @@
>     ScrnInfoPtr		pScrn = crtc->scrn;
>     ScreenPtr		pScreen = pScrn->pScreen;
>     xf86CrtcConfigPtr   xf86_config = XF86_CRTC_CONFIG_PTR(pScrn);
>+    DrawablePtr screenDrawable = &pScreen->root->drawable;
>     int			c;
>     
>     /* Free memory from rotation */
>@@ -300,12 +301,12 @@
>     /*
>      * Clean up damage structures when no crtcs are rotated
>      */
>-    if (xf86_config->rotation_damage)
>+    if (screenDrawable && xf86_config->rotation_damage)
>     {
> 	/* Free damage structure */
> 	if (xf86_config->rotation_damage_registered)
> 	{
>-	    DamageUnregister (&pScreen->root->drawable,
>+	    DamageUnregister (screenDrawable,
> 			      xf86_config->rotation_damage);
> 	    xf86_config->rotation_damage_registered = FALSE;
> 	    DisableLimitedSchedulingLatency();

Actions: View | Splinter Review

Attachments on bug 41653: 52211 | 59639

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.