Attachment 55362 Details for Bug 44609 – fix logic bug in windows condition variable

[patch] fix logic bug in windows condition variable

0001-Fix-logic-in-condition-variable-fairness.patch (text/plain), 1019 bytes, created by Marcus Brinkmann on 2012-01-09 18:43:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcus Brinkmann

Created: 2012-01-09 18:43:02 UTC

Size: 1019 bytes

patch

obsolete

>From 15f9ba201b856f27e9e160000cbc654b64957618 Mon Sep 17 00:00:00 2001
>From: Marcus Brinkmann <marcus.brinkmann@ruhr-uni-bochum.de>
>Date: Tue, 10 Jan 2012 03:38:21 +0100
>Subject: [PATCH] Fix logic in condition variable fairness.
>
>---
> dbus/dbus-sysdeps-thread-win.c |    6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
>diff --git a/dbus/dbus-sysdeps-thread-win.c b/dbus/dbus-sysdeps-thread-win.c
>index e2972a3..c46b45a 100644
>--- a/dbus/dbus-sysdeps-thread-win.c
>+++ b/dbus/dbus-sysdeps-thread-win.c
>@@ -233,12 +233,16 @@ _dbus_windows_condvar_wake_one (DBusCondVar *cond)
> static void
> _dbus_windows_condvar_wake_all (DBusCondVar *cond)
> {
>+  int any;
>+
>   EnterCriticalSection (&cond->lock);
> 
>+  any = (cond->list != NULL);
>+
>   while (cond->list != NULL)
>     SetEvent (_dbus_list_pop_first (&cond->list));
> 
>-  if (cond->list != NULL)
>+  if (any)
>     {
>       /* Avoid live lock by pushing the waiter to the mutex lock
>          instruction, which is fair.  If we don't do this, we could
>-- 
>1.7.4.1
>

Actions: View | Splinter Review

Attachments on bug 44609: 55362 | 57310

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.