Attachment 8487 Details for Bug 7205 – Patch for Mesa's resize() function

[patch] Patch for Mesa's resize() function

p_mesa_context.diff (text/plain), 1.26 KB, created by Matthias Hopf on 2007-01-23 11:45:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthias Hopf

Created: 2007-01-23 11:45:04 UTC

Size: 1.26 KB

patch

obsolete

>Novell bug #211314  (and probably others)
>Maybe xorg bug #7205
>
>
>The Mesa resize() function is called, while the current context _glapi_Context
>is NULL. As this isn't checked in the function I assume that this should never
>happen.
>
>Actually, it seems that while the context is correctly lost, the dispatch
>functions aren't cleared correctly. Resizing windows was the only (well, almost
>only) function that didn't check the validity of the glx context.
>
>Matthias Hopf <mhopf@suse.de>
>
>
>--- src/mesa/drivers/x11/xm_api.c.orig 	2006-11-30 20:45:42.000000000 +0100
>+++ src/mesa/drivers/x11/xm_api.c	2006-11-30 20:47:12.000000000 +0100
>@@ -2101,7 +2101,11 @@ static void FXgetImage( XMesaBuffer b )
>    static unsigned short pixbuf[MAX_WIDTH];
>    GLuint x, y;
>    GLuint width, height;
>-   XMesaContext xmesa = XMESA_CONTEXT(ctx);
>+   XMesaContext xmesa;
>+   
>+   if (! ctx)
>+     return;
>+   xmesa = XMESA_CONTEXT(ctx);
> 
> #ifdef XFree86Server
>    x = b->frontxrb->pixmap->x;
>@@ -2535,7 +2539,9 @@ void
> XMesaResizeBuffers( XMesaBuffer b )
> {
>    GET_CURRENT_CONTEXT(ctx);
>-   XMesaContext xmctx = XMESA_CONTEXT(ctx);
>-   xmesa_check_and_update_buffer_size(xmctx, b);
>+   if (ctx) {
>+     XMesaContext xmctx = XMESA_CONTEXT(ctx);
>+     xmesa_check_and_update_buffer_size(xmctx, b);
>+   }
> }
>

Actions: View | Splinter Review

Attachments on bug 7205: 5893 | 8257 | 8258 | 8487 | 8488 | 8501 | 8884

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.