Attachment 87614 Details for Bug 25147 – [spec next] Renaming: emit new identifier in Renamed signals

[patch] [spec next] Renaming: emit new identifier in Renamed signals

0001-Renaming-emit-new-identifier-in-Renamed-signals.patch (text/plain), 1.85 KB, created by Simon McVittie on 2013-10-14 17:02:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Simon McVittie

Created: 2013-10-14 17:02:18 UTC

Size: 1.85 KB

patch

obsolete

>From 7cf64e2ffbe10c1c505478c30370a68c0417bf5d Mon Sep 17 00:00:00 2001
>From: Simon McVittie <simon.mcvittie@collabora.co.uk>
>Date: Mon, 14 Oct 2013 17:19:18 +0100
>Subject: [PATCH] Renaming: emit new identifier in Renamed signals
>
>As a general design principle, signals that announce a new handle
>should announce its identifier too. This lets client libraries
>construct a TpContact, Tp::Contact etc. without a round trip.
>---
> spec/Connection_Interface_Renaming1.xml | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
>diff --git a/spec/Connection_Interface_Renaming1.xml b/spec/Connection_Interface_Renaming1.xml
>index f8e7ca8..16a8d49 100644
>--- a/spec/Connection_Interface_Renaming1.xml
>+++ b/spec/Connection_Interface_Renaming1.xml
>@@ -27,11 +27,23 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.</
> The handle of the original identifier
> </tp:docstring>
> </arg>
>- <arg name="New" type="u" tp:type="Contact_Handle">
>+ <arg name="New_Handle" type="u" tp:type="Contact_Handle">
> <tp:docstring>
> The handle of the new identifier
> </tp:docstring>
> </arg>
>+ <arg name="New_Identifier" type="s">
>+ <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
>+ The normalized identifier corresponding to New_Handle.
>+
>+ <tp:rationale>
>+ Providing this immediately means that client libraries
>+ can do useful things with this signal (log the change,
>+ construct contact objects, etc.) without an additional
>+ round-trip to find the corresponding string.
>+ </tp:rationale>
>+ </tp:docstring>
>+ </arg>
> <tp:docstring xmlns="http://www.w3.org/1999/xhtml">
> Emitted when the unique identifier of a contact on the server
> changes.
>-- 
>1.8.4.rc3
>

Actions: View | Splinter Review

Attachments on bug 25147: 87465 | 87614 | 88720 | 88721 | 88722

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.