From 85005da1a2aaf117829f5fd75a4e4c0b4eadfda8 Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Tue, 18 Jan 2011 16:34:12 +0000 Subject: [PATCH 2/2] handle_server_data_anonymous_mech: remove unnecessary debug output Doing a malloc and a hex-encoding pass just to produce a _dbus_verbose message (i.e. a message that, in practice, nobody will see) seems like overkill, and this block had incorrect error handling (not checking the result of _dbus_string_init) which upsets static analysis tools. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29881 Bug-NB: NB#180486 --- dbus/dbus-auth.c | 12 ------------ 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/dbus/dbus-auth.c b/dbus/dbus-auth.c index 3173f34..270d85e 100644 --- a/dbus/dbus-auth.c +++ b/dbus/dbus-auth.c @@ -1202,18 +1202,6 @@ handle_server_data_anonymous_mech (DBusAuth *auth, { _dbus_verbose ("%s: Received invalid UTF-8 trace data from ANONYMOUS client\n", DBUS_AUTH_NAME (auth)); - - { - DBusString plaintext; - DBusString encoded; - _dbus_string_init_const (&plaintext, "D-Bus " DBUS_VERSION_STRING); - _dbus_string_init (&encoded); - _dbus_string_hex_encode (&plaintext, 0, - &encoded, - 0); - _dbus_verbose ("%s: try '%s'\n", - DBUS_AUTH_NAME (auth), _dbus_string_get_const_data (&encoded)); - } return send_rejected (auth); } -- 1.7.2.3