Bug 11830

Summary:

[PATCH] Multiple randr1.2 fixes

Product:

xorg

Reporter:

Gustavo Pichorim Boiko <boiko>

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Keywords:

patch

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Bug Depends on:

Bug Blocks:

8888

Attachments:

Description	Flags
Fix a small error that was causing a stack corruption	none
Fix randr1.2 loading on non-randr1.2 DDX in a better way	none
Make sure outputs get updated when getting info	none

Description Gustavo Pichorim Boiko 2007-08-03 07:38:16 UTC

0001-Allocate-the-right-number-of-entries-for-saving-crtc.patch
   This first patch fixes a small error that causes a stack corruption because of a function allocating less entries in a array than the ones it was using in the rest of the function

0002-Fix-randr1.2-loading-on-non-randr1.2-DDX-in-a-better.patch
   This is basically a reimplementation of 8d230319040f0a7f72231da2bf5ec97dc3612e21 in a way to preserve the abstraction layer (as suggested by Keith Packard)

0003-Make-sure-outputs-get-updated-when-getting-info.patch
   When setting the randr1.2 info, make sure outputs get their crtcs updated

Comment 1 Gustavo Pichorim Boiko 2007-08-03 07:39:07 UTC

Created attachment 10977 [details] [review]
Fix a small error that was causing a stack corruption

Comment 2 Gustavo Pichorim Boiko 2007-08-03 07:40:13 UTC

Created attachment 10978 [details] [review]
Fix randr1.2 loading on non-randr1.2 DDX in a better way

Comment 3 Gustavo Pichorim Boiko 2007-08-03 07:41:16 UTC

Created attachment 10979 [details] [review]
Make sure outputs get updated when getting info

Comment 4 Gustavo Pichorim Boiko 2007-08-08 12:17:39 UTC

Comment on attachment 10979 [details] [review]
Make sure outputs get updated when getting info

This patch was double checked and I verified it is not needed in fact. Initialization is done in xf86RandR12CreateScreenResources12

Comment 5 Gustavo Pichorim Boiko 2007-08-08 12:39:48 UTC

The following commits provide exactly the same fixes as these bugs:
2926cf1da7e4ed63573bfaecdd7e19beb3057d9b
b2dcfbca2441ca8c561f86a78a76ab59ecbb40e4
b4193a2eee80895c5641e77488df0e72a73a3d99

Closing this bug as fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.