Bug 16418

Created attachment 17219 [details] [review]
Sorry is diff for driver

Jesse/Zhenyu, any of you would review the patch?

It`s only one string to support /sys/class/backlight/asus-laptop mode.

Kernel: [root@sfbook asus-laptop]# uname -a
Linux sfbook.sadnet.lo 2.6.25.7 #1 SMP Tue Jun 17 23:31:25 OMSST 2008 i686 Intel(R) Celeron(R) CPU          540  @ 1.86GHz GNU/Linux

Please include this patch to the driver code.

Zhao Yakui <yakui.zhao@intel.com> sad:
"It seems that the driver of asus-acpi is still used. Now it is
depreciated. Please use the asus-laptop driver and see whether the
problem still exists.( Set CONFIG_ASUS_LAPTOP in kernel configuration)."

Patch it`s work on asus X51L. 

Sorry my English. 

The problem is shown at switching in the console or at start fullscreen OpenGL appendices. Brightness decreases up to a minimum and is restored only in manual back.

Too most occurs at change of sanctions or at transition in a sleeping mode.

Please name me Evgeniy or John;)
John R.Manachkin - sounds;)

Yeah, last time when I looked into asus_acpi, it hasn't provided any sysfs backlight control support, though I did a patch against xf86-video-intel to use /proc/acpi/asus instead. And now it looks current kernel has sysfs support ready, cool.

Actually I also did some work on eeepc-acpi in debian to work with video driver too, it also looks already available in current kernel git. So we can add both
to our video driver.

(In reply to comment #6)
> So we can add both to our video driver.

It`s good !

I've pushed your patch with eeepc support too. Thanks!

ooops... code is wrong.

Please edit i830_lvds.c.

Lines "acpi_video1","acpi_video0", should be "thinkpad_screen", "fujitsu-laptop", "asus-laptop","eeepc", below lines. 

It is very important for correct work!

True code down:

static char *backlight_interfaces[] = {
    "thinkpad_screen",
    "fujitsu-laptop",
    "asus-laptop",
    "eeepc",
    "acpi_video1",
    "acpi_video0",
    NULL,
};

oh, so you've seen both acpi_videoX and asus-laptop backlight method under /sys/class/backlight?

[sfstudio@sfbook backlight]$ ls
acpi_video0/  asus-laptop/

[sfstudio@sfbook backlight]$ uname -a
Linux sfbook.sadnet.lo 2.6.25.9 #5 SMP Fri Jun 27 00:40:11 OMSST 2008 i686 Intel(R) Celeron(R) CPU          540  @ 1.86GHz GNU/Linux

ok, so acpi_video method doesn't work but asus does right?

I might push a patch to pre-order asus and eeepc interface than acpi ones.

P.S.  acpi_video0 does not work.

Thanks a lot, I've pushed the fix.

In 2.6.26 kernel "/sys/class/backlight/asus-laptop" moved to "/sys/class/backlight/asus".

To support backligth it 2.6.26 please add "asus" method.

True code:

/*
 * List of available kernel interfaces in priority order
 */
static char *backlight_interfaces[] = {
    "asus-laptop",
    "asus",
    "thinkpad_screen",
    "acpi_video1",
    "acpi_video0",
    "fujitsu-laptop",
    NULL,
};

Are you sure? I haven't seen changes from kernel log.

Sure.

[root@sfbook sfstudio]# uname -a
Linux sfbook.sadnet.lo 2.6.26 #1 SMP Tue Jul 15 05:23:28 OMSST 2008 i686 Intel(R) Celeron(R) CPU          540  @ 1.86GHz GNU/Linux


[root@sfbook sfstudio]# ls /sys/class/backlight/asus
actual_brightness  bl_power  brightness  max_brightness  power/  subsystem@  uevent

[root@sfbook sfstudio]# ls /sys/class/backlight/asus-laptop
ls: cannot access /sys/class/backlight/asus-laptop: No such file or directory

I suggest to add a method asus. To not clean asus-laptop to keep compatibility with older kernels.

Sure.

[root@sfbook sfstudio]# uname -a
Linux sfbook.sadnet.lo 2.6.26 #1 SMP Tue Jul 15 05:23:28 OMSST 2008 i686 Intel(R) Celeron(R) CPU          540  @ 1.86GHz GNU/Linux


[root@sfbook sfstudio]# ls /sys/class/backlight/asus
actual_brightness  bl_power  brightness  max_brightness  power/  subsystem@  uevent

[root@sfbook sfstudio]# ls /sys/class/backlight/asus-laptop
ls: cannot access /sys/class/backlight/asus-laptop: No such file or directory

I suggest to add a method asus. To not clean asus-laptop to keep compatibility with older kernels.

Opps Sorry.

If CONFIG_ACPI_ASUS=y - use /sys/class/backlight/asus for backligth.

If CONFIG_ASUS_LAPTOP=m - use /sys/class/backlight/asus-laptop for backligth.

I consider that it is necessary to support both versions since ASUS_LAPTOP while it is marked EXPEREMENTAL.

Moreover, at CONFIG_ASUS_LAPTOP=m does not work wireless led. Therefore support asus and asus-laptop is necessary.