Bug 17876

Created attachment 19343 [details] [review]
Patch to fix rarian-man.c child process/pipe issues

Two issues here both being caused by librarian on solaris.

1. rarian-man.c, forks a child to run manpath, however it uses exit() to exit
   the child, which is incorrect, it should use _exit() to exit the child
   If it does not then the childs file descriptors are left open and cause
   confusion down the line and result in yelp constantly polling one of the 
   open FD's, which in turn results in yelp consuming 50%+ of CPU... not good.

2. rarian-man.c should also call waitpid() on the child process, to ensure it
   exits, if it dosen't you end up with a defunct process lying around.

3. I've also noticed that rarian-man.c, closes/dups stdin and stdout this is
   really unecessary, as they are not being used.

The attached patch resolves the above three issues by :
 
  1. Calling _exit(0) instead of exit(0) for the child, this is by far the 
     must have fix, as this resolves the CPU hogging...
  2. Remove the closing/dup'ing of stdin and stdout, not needed, and moving
     the dup2 calls inside the child logic
  3. calling waitpid to ensure child has exited, and thus not ending up
     with a defunct process lying around.