Bug 20908

Summary: Observer: [impl needed] ObserveChannels should also take a Channel_Request[]
Product: Telepathy Reporter: Simon McVittie <smcv>
Component: tp-specAssignee: Simon McVittie <smcv>
Status: RESOLVED FIXED QA Contact: Telepathy bugs list <telepathy-bugs>
Severity: normal    
Priority: medium Keywords: patch
Version: unspecified   
Hardware: Other   
OS: All   
URL: http://git.collabora.co.uk/?p=user/smcv/telepathy-spec-smcv.git;a=shortlog;h=refs/heads/observer-abibreak
Whiteboard:
i915 platform: i915 features:
Bug Depends on: 20909    
Bug Blocks: 21148    

Description Simon McVittie 2009-03-27 07:59:08 UTC
When ObserveChannels() is called on an observer C which is also a Handler, it
can't tell if those channels satisfy a request it knows about.

* AddRequest() is called on a client C (because it, or something else,
requested a channel).
* C opens a tab or similar to represent the ongoing request.
* The channel appears. MC calls ObserveChannels() on all matching clients,
including C.
* C doesn't know that the new channel relates to the ongoing request; it opens
a new UI element for it.
* Now HandleChannels() is called, including the channel and the requests it
satisfies. Only now can C tell that the channel referred to that request.

The obvious fix is to add ao: Requests_Satisfied to ObserveChannels(), just as
the related ChannelDispatchOperation is already a parameter to
ObserveChannels().
Comment 2 Simon McVittie 2009-04-14 07:54:15 UTC
Merged in git and will be in 0.17.23, but still needs implementation

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.