| Summary: | [PATCH] xprop does not select correct client window in WM's using virtual roots | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Kim Woelders <kim> | ||||||||||||
| Component: | App/xprop | Assignee: | James Cloos <cloos> | ||||||||||||
| Status: | CLOSED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | high | CC: | erik.andren | ||||||||||||
| Version: | 6.8.1 | Keywords: | patch | ||||||||||||
| Hardware: | x86 (IA32) | ||||||||||||||
| OS: | Linux (All) | ||||||||||||||
| Whiteboard: | |||||||||||||||
| i915 platform: | i915 features: | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Kim Woelders
2005-01-01 02:55:39 UTC
Created attachment 1608 [details] [review] Fix window selection by pointer Adding patch keyword Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future. Ok, two and a half year has passed, time to try again... :) The patch about to be attached should fix various client selection issues such as the problem with virtual roots (this bug) and the problem with child stack search order (bug 2135 and bug 7474). I have put the new window selection code in a separate file so it could be either copied to the other apps that have the same problems (xwininfo, xkill, xwd, others?) or included in some library (libXmuu like the broken XmuClientWindow?). Created attachment 11126 [details] [review] Fix window selection by pointer - take 2 I pushed this in commit e09956f244099ddd36b1a2cd5d7800d5fc7120c1. Patches for other apps like xwd and xwininfo would not be unwelcome.... First, I should mention that my second patch, which was committed as per comment 6, does not exactly match the description given in comment 1, which was used as the git commit message. The problem with the original patch was (IIRC) that simply descending the window stack at the pointer location would not find a client if it was selected by clicking its window manager border. My second patch instead checks if the child of root selected by the mouse click is a virtual root (i.e. listed in _NET_VIRTUAL_ROOTS). If so the child of the virtual root at the pointer location is used as the starting point (the new subwin) for finding an inferior with WM_STATE set. The first two patches about to be attached fix the client selection by pointer issue for xwininfo and xwd. The changes are functionally the same as the ones committed to xprop, and the patches duplicate clientwin.c/h code in each of the app directories. I'm not very happy with duplicating code like this. Maybe it could be moved to some library, as previously suggested? The dsimple.c/h's are also practically identical and could easily be merged. The third patch performs the same cleanups to xwd/dsimple.c/h that already have been done in the xprop and xwininfo versions. Created attachment 13360 [details] [review] xwininfo - Fix window selection by pointer. Created attachment 13361 [details] [review] xwd - Fix window selection by pointer. Created attachment 13362 [details] [review] xwd - Cleanups. Comment on attachment 13361 [details] [review] xwd - Fix window selection by pointer. ->patch Comment on attachment 13362 [details] [review] xwd - Cleanups. ->patch Bugzilla Upgrade Mass Bug Change
NEEDSINFO state was removed in Bugzilla 3.x, reopening any bugs previously listed as NEEDSINFO.
- benjsc
fd.o Wrangler
Ping? Patches made as suggested, about half a year ago. Sorry for the delay. I let this one slip out of mem.... :^( Attachment 13360 [details] pushed to xwininfo as c229611bcb7ee94bea5c075f5e15447e14c0f6ce. Attachment 13361 [details] pushed to xwd as 3dcc66bbbc74c41c2b4509a785c3688fd75387a1. Attachment 13362 [details] pushed to xwd as f9725928e875035bd2a96621aa8f861160e85dd7. I’ll also push out tar releases (xwd-1.0.2 and xwininfo-1.0.4). xwd-1.0.2 and xwininfo-1.0.4 tars are pushed. Closing. Much thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.