| Summary: | Regression: rendering corruption (z-order problems) with fvwm menus | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | xorg | Reporter: | Nick Bowler <nbowler> | ||||||||||
| Component: | Driver/intel | Assignee: | Eric Anholt <eric> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | Xorg Project Team <xorg-team> | ||||||||||
| Severity: | normal | ||||||||||||
| Priority: | medium | ||||||||||||
| Version: | unspecified | ||||||||||||
| Hardware: | Other | ||||||||||||
| OS: | All | ||||||||||||
| Whiteboard: | |||||||||||||
| i915 platform: | i915 features: | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Nick Bowler
2010-08-04 12:03:55 UTC
Looks like Dave's patch uncovered the bug in that my code doesn't appear to be honouring clipping correctly. Thanks. The bug Chris was referring to (I think) is fixed in: commit e0066e77e026b0dd0daa0c3765473c7d63aa6753 Author: Eric Anholt <eric@anholt.net> Date: Tue May 31 23:17:16 2011 -0700 uxa: Simplify Composite solid acceleration for spans by only clipping once. Unlike the previous commit removing this style of code, the code in this one was originally wrong, and would fail to clip in the second pass of clipping when y was > pbox->y2. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=37233 Reviewed-by: Keith Packard <keithp@keithp.com> Created attachment 47743 [details]
New menu artifacts.
Unfortunately, it appears that the issue is not quite fixed. While the
triangles no longer render on top of other menus, now they sometimes don't
render at all. After opening and closing a bunch of submenus (which
temporarily obscures some of the triangles), I end up with a menu that's
missing bits. The triangles reappear spontaneously as you select various menu
items.
Just to clarify: there are no problems with the menus prior to the commit
implicated in the original post.
Created attachment 47744 [details]
Correctly rendered menu.
For reference, here's what the menu is _supposed_ to look like.
Nick, I need a few more instructions on driving FVWM to reproduce your menus. I think these were all fixed with sna.. Created attachment 47774 [details] Sample FVWM config (In reply to comment #5) > Nick, I need a few more instructions on driving FVWM to reproduce your menus. The attached config file can be used to reproduce the issue. After experimenting a bit, I've discovered that the issue is most easily reproduced by opening the menu on the right hand side of the screen, so that the submenus open to the *left* of the main menu. It then becomes apparent that the triangles in the main menu will disappear if they are forced to be redrawn (e.g. by highlighting a menu item) and they are either to the right or below the submenu (triangles above the submenu are not affected, and I'm not sure if it's possible for triangles to appear to the left of a submenu). > I think these were all fixed with sna.. Indeed, enabling sna appears to fix the menus, but of course you need an X server release from the future (else apply patches from the mailing list) to use that. The code is gone: commit 855ced5a4eb67e287001ae22cb6489639c548cfa Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Thu Jun 16 13:24:14 2011 +0100 uxa: Remove the attempt to use the 3D pipeline for core rendering The attempt was still ridden with bugs, such as http://bugs.freedesktop.org/show_bug.cgi?id=28768 http://bugs.freedesktop.org/show_bug.cgi?id=28798 http://bugs.freedesktop.org/show_bug.cgi?id=28908 http://bugs.freedesktop.org/show_bug.cgi?id=29401 A fresh approach was taken with SNA, but in the mean time before that can be enabled downstream, restore correct behaviour. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.