Bug 37627

Summary:	Coverity scan
Product:	Rarian	Reporter:	mluscon
Component:	General	Assignee:	Don Scorgie <Don>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description mluscon 2011-05-26 06:40:55 UTC

Coverity scan of Fedora 15 rarian package has been analysed and I have found fallowing issues:

/librarian/rarian-reg-full.c:683 - potential null dereferencing in function strcmp

/librarian/rarian-reg-utils.c:420 - missing return in fucntion rrn_sect_new

/util/tinyxml.cpp:1047 - function ftell may return a negative number

/librarian/rarian-man.c:96,97 - function dup may return a negative number

/util/rarian-sk-get-cl.cpp:174 - resource leak of variable basepath

/librarian/rarian-reg-full.c:627 - resource leak of variable lang

/librarian/rarian-reg-full.c:719 - resource leak variable prefix

/librarian/rarian-reg-full.c:338 - resource leak of variable lang

It would be good check return value of every malloc and other functions which may cause null dereferencing. If you don't want cover this by yourself, I can create a patch with proposal of solutions.  

In the case of interest, contact me and I will send to you the whole coverity report.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.