Summary: | add public API to validate various fixed-syntax strings | ||
---|---|---|---|
Product: | dbus | Reporter: | Simon McVittie <smcv> |
Component: | core | Assignee: | Simon McVittie <smcv> |
Status: | RESOLVED FIXED | QA Contact: | John (J5) Palmieri <johnp> |
Severity: | enhancement | ||
Priority: | medium | CC: | hp |
Version: | 1.5 | Keywords: | patch |
Hardware: | Other | ||
OS: | All | ||
URL: | http://cgit.freedesktop.org/~smcv/dbus/log/?h=validation-39549 | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Bug Depends on: | |||
Bug Blocks: | 36164, 40817 | ||
Attachments: |
[PATCH 1/3] Remove declaration of _dbus_type_is_fixed, no longer exists
[PATCH 2/3] Add dbus-syntax.[ch] [PATCH 3/3] Add a regression test for validating various string types with the public API |
Description
Simon McVittie
2011-07-26 04:20:44 UTC
Created attachment 49562 [details] [review] [PATCH 1/3] Remove declaration of _dbus_type_is_fixed, no longer exists Created attachment 49563 [details] [review] [PATCH 2/3] Add dbus-syntax.[ch] Created attachment 49564 [details] [review] [PATCH 3/3] Add a regression test for validating various string types with the public API Branch updated for current master (just patches 2 and 3, I've moved the first one to a trivia branch): ssh://people.freedesktop.org/~smcv/dbus.git validation-39549 Comment on attachment 49562 [details] [review] [PATCH 1/3] Remove declaration of _dbus_type_is_fixed, no longer exists Review of attachment 49562 [details] [review]: ----------------------------------------------------------------- Looks fine. Comment on attachment 49563 [details] [review] [PATCH 2/3] Add dbus-syntax.[ch] Review of attachment 49563 [details] [review]: ----------------------------------------------------------------- This look reasonable too. Comment on attachment 49564 [details] [review] [PATCH 3/3] Add a regression test for validating various string types with the public API Review of attachment 49564 [details] [review]: ----------------------------------------------------------------- Looks fine. Thanks, fixed in git for 1.5.12 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.