Bug 40002

Summary:	avoid dead code in bus/main.c on non-Unix
Product:	dbus	Reporter:	Simon McVittie <smcv>
Component:	core	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	John (J5) Palmieri <johnp>
Severity:	trivial
Priority:	low	CC:	hp, ralf.habacker
Version:	1.5	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	36164
Attachments:	Don't build any of the reload-pipe code on non-Unix

Description Simon McVittie 2011-08-11 03:34:33 UTC

Created attachment 50116 [details] [review]
Don't build any of the reload-pipe code on non-Unix

In commit ab7b3f9, Ralf notes that handle_reload_watch() is (in principle) cross-platform. However, there's no way to trigger it on Windows, because nothing ever writes to the pipe (the only way to reload on Windows is ReloadConfig(), which just does the reload there and then, without messing about with Unix signals). It seems cleaner to make the entire pipe-to-self trick Unix-specific instead.

Comment 1 Will Thompson 2011-08-25 10:32:47 UTC

Review of attachment 50116 [details] [review]:

This looks fine, ship it.

Comment 2 Simon McVittie 2011-08-26 07:17:52 UTC

Thanks, fixed in git for 1.4.16, 1.5.8

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.