Bug 43880

Summary:	--enable-gtk-doc makes tp-ytstenut build fail
Product:	Ytstenut	Reporter:	Alvaro Soliverez <alvaro.soliverez>
Component:	tp-ytstenut	Assignee:	Alvaro Soliverez <alvaro.soliverez>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	high	CC:	olli.salli
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	review+
i915 platform:		i915 features:
Attachments:	0001-build-move-docs-to-come-last-in-the-toplevel-Makefil.patch

Description Alvaro Soliverez 2011-12-16 05:09:05 UTC

Some options are not working correctly when trying to build tp-ytstenut.

First, it does not detect TpQt4 correctly. Having all dev headers installed, it does not detect them, and the configure throws an error.

--enable-gtk-doc throws this error:

make[3]: Entering directory `/var/lib/buildbot/telepathy/tp-yts-default-amd64/build/docs/reference'
make[3]: *** No rule to make target `../../telepathy-ytstenut-glib/_gen/*.h', needed by `scan-build.stamp'.  Stop.
make[3]: Leaving directory `/var/lib/buildbot/telepathy/tp-yts-default-amd64/build/docs/reference'
make[2]: *** [all-recursive] Error 1

See here, for more reference: http://buildbot.telepathy.im/builders/telepathy-ytstenut%20-%20amd64/builds/0/steps/compile


Also, the build cannot be executed out-of-tree, because it throws errors in generated files:
In file included from ../../telepathy-ytstenut-glib/status.c:33:0:
../../telepathy-ytstenut-glib/extensions/connection-future.h:41:40: fatal error: _gen/cli-connection-future.h: No such file or directory
compilation terminated.
make[4]: *** [status.lo] Error 1

See here: http://buildbot.telepathy.im/baauilders/telepathy-ytstenut - i386/builds/3

Also, it doesn't have a make clean target.

Comment 1 Olli Salli 2012-01-08 08:05:19 UTC

(In reply to comment #0)
> --enable-gtk-doc throws this error:
> 
> make[3]: Entering directory
> `/var/lib/buildbot/telepathy/tp-yts-default-amd64/build/docs/reference'
> make[3]: *** No rule to make target `../../telepathy-ytstenut-glib/_gen/*.h',
> needed by `scan-build.stamp'.  Stop.
> make[3]: Leaving directory
> `/var/lib/buildbot/telepathy/tp-yts-default-amd64/build/docs/reference'
> make[2]: *** [all-recursive] Error 1
> 
> See here, for more reference:
> http://buildbot.telepathy.im/builders/telepathy-ytstenut%20-%20amd64/builds/0/steps/compile
> 

I got this too, while building (specifically to be able to take a look at the documentation). As a workaround, I first built it with --disable-gtk-doc, then ran configure again with --enable-gtk-doc, at which point it built fine including docs.

So it's some kind of dependency problem...

Comment 2 Rob Staudinger 2012-01-10 05:19:29 UTC

Created attachment 55381 [details] [review]
0001-build-move-docs-to-come-last-in-the-toplevel-Makefil.patch

Author: Rob Staudinger <robsta@linux.intel.com>
Date:   Tue Jan 10 14:13:59 2012 +0100

    build: move "docs" to come last in the toplevel Makefile's SUBDIRS
    
    The docs build depends on generated headers for the DBus interfaces,
    so it needs to come after the very generation of those.

Comment 3 Olli Salli 2012-01-12 03:33:08 UTC

(In reply to comment #2)
> Created attachment 55381 [details] [review] [review]
> 0001-build-move-docs-to-come-last-in-the-toplevel-Makefil.patch
> 
> Author: Rob Staudinger <robsta@linux.intel.com>
> Date:   Tue Jan 10 14:13:59 2012 +0100
> 
>     build: move "docs" to come last in the toplevel Makefile's SUBDIRS
> 
>     The docs build depends on generated headers for the DBus interfaces,
>     so it needs to come after the very generation of those.

Looks good and fixed the issue for me.

Alvaro: do you have a patch fixing the OOB build and make clean? If not, still have to create and review that.

Comment 4 Rob Staudinger 2012-01-12 03:42:05 UTC

Ah those pesky lumped bug reports, if you don't have a patch for the out-of-tree build and clean assign back, and I'll look at it.

Comment 5 Alvaro Soliverez 2012-01-12 03:50:09 UTC

make clean is working fine, it was bad testing on my side.

The out-of-tree build still needs a fix.

Comment 6 Robert Staudinger 2012-01-16 05:00:49 UTC

Moving the out-of-tree issue to #44828 so we have one bug per ticket.

Comment 7 Olli Salli 2012-02-03 03:13:16 UTC

This patch deemed good already. Adj'ing bug description - and this doesn't really block the OOB issue either.

Comment 8 Robert Staudinger 2012-02-16 02:14:46 UTC

Patch pushed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.