Bug 44828

Summary: Out-of-tree build does not work
Product: Ytstenut Reporter: Robert Staudinger <robert.staudinger>
Component: tp-ytstenutAssignee: Robert Staudinger <robert.staudinger>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: alvaro.soliverez, olli.salli
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
Whiteboard: review+
i915 platform: i915 features:
Attachments: 0002-build-add-builddir-to-includes-to-allow-for-out-of-t.patch

Description Robert Staudinger 2012-01-16 04:59:28 UTC
Building telepathy-ytstenut outside the source tree fails.
Comment 1 Robert Staudinger 2012-01-16 05:04:06 UTC
Created attachment 55634 [details] [review]
0002-build-add-builddir-to-includes-to-allow-for-out-of-t.patch

From: Rob Staudinger <robsta@linux.intel.com>
Date: Mon, 16 Jan 2012 13:56:46 +0100
Subject: [PATCH 2/2] build: add builddir to includes to allow for out-of-tree
 builds

In an out of tree build the generated headers would end up below
$(top_builddir). Add this directory to the include path, so the
required headers are found.

Fixes: #44828
Comment 2 Robert Staudinger 2012-01-16 05:05:37 UTC
One-liner fix, but give me a nod to test the review process :)
Comment 3 Robert Staudinger 2012-01-16 05:06:50 UTC
Adding Alvaro since he originally reported that issue in #43880.
Comment 4 Robert Staudinger 2012-01-17 00:35:33 UTC
Good to go?
Comment 5 Olli Salli 2012-02-03 03:17:34 UTC
(In reply to comment #4)
> Good to go?

++, please merge and resolve
Comment 6 Robert Staudinger 2012-02-03 03:50:37 UTC
commit f163ef2f2e6f230acd1005780f7b6d780f2fc6da (HEAD, origin/master, origin/HEAD, master)
Author: Rob Staudinger <robsta@linux.intel.com>
Date:   Mon Jan 16 13:56:46 2012 +0100

    build: add builddir to includes to allow for out-of-tree builds
    
    In an out of tree build the generated headers would end up below
    $(top_builddir). Add this directory to the include path, so the
    required headers are found.
    
    Fixes: #44828

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.