|
Description
Simon McVittie
2012-02-15 04:24:54 UTC
Created attachment 57080 [details] [review] [PATCH 01/10] _dbus_verbose_real: tidy conditional prototype to not break nesting The mismatched opening parenthesis caused vim syntax highlighting to consider every subsequent brace in the file to be an error, which was pretty annoying. Created attachment 57081 [details] [review] [PATCH 02/10] Remove declaration of _dbus_type_is_fixed, no longer exists Created attachment 57082 [details] [review] [PATCH 03/10] Add a macro to centralize checking for string-like types Created attachment 57083 [details] [review] [PATCH 04/10] internal_bus_get: centralize error handling Created attachment 57084 [details] [review] [PATCH 05/10] Invoke PKG_PROG_PKG_CONFIG early in configure.ac Otherwise, autoconf can generate wrong code, because our first use of PKG_CHECK_MODULES is conditional. Created attachment 57085 [details] [review] [PATCH 06/10] Do not AC_SUBST systemd flags from PKG_CHECK_MODULES They're automatically substituted already. Created attachment 57086 [details] [review] [PATCH 07/10] Zero-initialize DBusCounter at allocation Created attachment 57087 [details] [review] [PATCH 08/10] DBusTransport: don't use dbus-message-private.h It seems it's no longer needed here. Created attachment 57088 [details] [review] [PATCH 09/10] Move _dbus_check_fdleaks_enter to dbus-message-internal.h This means the bus test can use them without needing dbus-message-private.h, reducing its view of message internals. Created attachment 57089 [details] [review] [PATCH 10/10] DBusTransport: don't include dbus-marshal-header.h either No longer needed. Comment on attachment 57080 [details] [review] [PATCH 01/10] _dbus_verbose_real: tidy conditional prototype to not break nesting Review of attachment 57080 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 57081 [details] [review] [PATCH 02/10] Remove declaration of _dbus_type_is_fixed, no longer exists Review of attachment 57081 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 57082 [details] [review] [PATCH 03/10] Add a macro to centralize checking for string-like types Review of attachment 57082 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 57083 [details] [review] [PATCH 04/10] internal_bus_get: centralize error handling Review of attachment 57083 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 57084 [details] [review] [PATCH 05/10] Invoke PKG_PROG_PKG_CONFIG early in configure.ac Review of attachment 57084 [details] [review]: ----------------------------------------------------------------- I trust you on this. Comment on attachment 57085 [details] [review] [PATCH 06/10] Do not AC_SUBST systemd flags from PKG_CHECK_MODULES Review of attachment 57085 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 57086 [details] [review] [PATCH 07/10] Zero-initialize DBusCounter at allocation Review of attachment 57086 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 57087 [details] [review] [PATCH 08/10] DBusTransport: don't use dbus-message-private.h Review of attachment 57087 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 57088 [details] [review] [PATCH 09/10] Move _dbus_check_fdleaks_enter to dbus-message-internal.h Review of attachment 57088 [details] [review]: ----------------------------------------------------------------- ++ Comment on attachment 57089 [details] [review] [PATCH 10/10] DBusTransport: don't include dbus-marshal-header.h either Review of attachment 57089 [details] [review]: ----------------------------------------------------------------- ++ All merged, thanks. 1.5.10 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.