Bug 49213

Maybe API name could be rearanged, like removing the _contact suffix if we only keep TpContact variants

(In reply to comment #0)
> In master we could already mark them as deprecated

Sure.

(In reply to comment #1)
> Maybe API name could be rearanged, like removing the _contact suffix if we only
> keep TpContact variants

Yes, in next.

If we do want to keep some handle-based APIs - like get_thing (TpHandle) -> Thing - we could rename those out of the way, to get_thing_by_handle or something. General design principle: when compatibility allows it (or when breaking compat already), the thing you want to use most of the time gets the shorter name and the obscure thing gets the longer name.

I think that all TpHandle of type TP_HANDLE_TYPE_CONTACT must disappear totally from the API and replaced by TpContact.

On TpChannel the only remaining TpHandle should be the channel's handle since it could be something else than a contact.

Created attachment 60661 [details] [review]
Bump GLib required version to 2.32

Created attachment 60662 [details] [review]
TpChannel: Deprecate all TpHandle APIs that have TpContact variant

Comment on attachment 60661 [details] [review]
Bump GLib required version to 2.32

Review of attachment 60661 [details] [review]:
-----------------------------------------------------------------

::: configure.ac
@@ +204,2 @@
>  
> +AC_DEFINE([GLIB_VERSION_MIN_REQUIRED], [GLIB_VERSION_2_32], [Ignore post 2.32 deprecations])

Don't we want to ignore the deprecation of GValueArray for now?

Comment on attachment 60662 [details] [review]
TpChannel: Deprecate all TpHandle APIs that have TpContact variant

Review of attachment 60662 [details] [review]:
-----------------------------------------------------------------

Looks fine.

::: examples/client/inspect-channel.c
@@ +73,4 @@
>          {
> +          TpContact *member = g_ptr_array_index (members, i);
> +
> +          printf ("\tcontact #%u\n", tp_contact_get_handle (member));

It'd be nice to printf the identifier too, now that it's trivial.

fixed and merged patches to master.