Bug 49398

Summary:	define D-Bus error names corresponding to members of Channel_Text_Send_Error
Product:	Telepathy	Reporter:	Rohan Garg <rohan>
Component:	tp-spec	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	enhancement
Priority:	medium	Keywords:	love
Version:	unspecified
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Rohan Garg 2012-05-02 12:26:39 UTC

Turns out that  ReceivedMessage::DeliveryDetails::error provides more specific error messages than ReceivedMessage::DeliveryDetails::dbusError

Hence, the error messages in ChannelTextSendError must be included in the list of error strings in the telepathy-spec so that ReceivedMessage::DeliveryDetails::dbusError provides specific error messages

Comment 1 Simon McVittie 2012-05-02 12:32:44 UTC

Adjusting summary a bit.

The general principle is that whenever we emit an (enum member, string error name) pair, the string error name is meant to be at least as specific as the enum member.

In this case, we can't (always) do that, because, for instance, there is no D-Bus error name that corresponds to "message too long":

20:13 < shadeslayer> It's just that  ReceivedMessage::DeliveryDetail::error is 
                     giving me ChannelTextSendErrorTooLong whereas  
                     ReceivedMessage::DeliveryDetails::dbusError gives me 
                     org.freedesktop.Telepathy.Error.InvalidArgument for the 
                     exact same error

Comment 2 Simon McVittie 2014-01-07 14:22:48 UTC

patches welcome, but not a spec 1.0 blocker

Comment 3 GitLab Migration User 2019-12-03 20:26:13 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-spec/issues/136.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.