Bug 50886

Summary:	Consider removing tp_handle_set_qdata()
Product:	Telepathy	Reporter:	Xavier Claessens <xclaesse>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	Keywords:	patch
Version:	unspecified
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=qdata
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	31668

Description Xavier Claessens 2012-06-08 09:27:34 UTC

As I understand it, the idea is to attach data to handles so it gets freed when handle is unreffed. But now that handles are immortal it could be dangerous to attach data to it.

For example, I think gabble attach alias, but if we leave a muc we could want to free all aliases even if the handles needs to be immortal.

Comment 1 Simon McVittie 2012-09-06 11:08:02 UTC

(In reply to comment #0)
> For example, I think gabble attach alias, but if we leave a muc we could want
> to free all aliases even if the handles needs to be immortal.

Does Gabble still do this? If it does, it shouldn't (and that should happen on master). Then we can delete this function, I think.

Comment 2 Xavier Claessens 2012-09-06 13:15:13 UTC

Here is the tp-glib master patch to deprecate tp_handle_set/get_qdata(): http://cgit.collabora.com/git/user/xclaesse/telepathy-glib.git/log/?h=qdata

However it is still used by gabble and idle.

Comment 3 Xavier Claessens 2012-09-11 08:45:43 UTC

Deprecated in tp-glib master. I'll open another bug to stop using it in gabble.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.