| Summary: | Provide GVariant-based access to TpContact:location | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | tp-glib | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | enhancement | ||
| Priority: | medium | Keywords: | patch |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Bug Depends on: | |||
| Bug Blocks: | 30422 | ||
| Attachments: |
contacts test: correct comparison of locations
tp_contact_dup_location, TpContact:location-vardict: add |
||
|
Description
Simon McVittie
2012-09-19 14:33:12 UTC
Created attachment 67386 [details] [review] contacts test: correct comparison of locations The values are GValues, not strings. This only appeared to work by chance: struct _GValue starts with a GType, and G_TYPE_STRING is '@', so on little-endian platforms interpreting a GValue as a string gives { '@', 0, 0, 0 } = "@" and on big-endian platforms it gives { 0, 0, 0, '@' } = "". Created attachment 67387 [details] [review] tp_contact_dup_location, TpContact:location-vardict: add Comment on attachment 67386 [details] [review] contacts test: correct comparison of locations Review of attachment 67386 [details] [review]: ----------------------------------------------------------------- funny :) ++ Comment on attachment 67387 [details] [review] tp_contact_dup_location, TpContact:location-vardict: add Review of attachment 67387 [details] [review]: ----------------------------------------------------------------- ++ Merged to master for 0.19.10 (or 0.20.0 depending on which one we release). |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.