Bug 59757

Summary:	const gchar ** arguments are inferred to be utf8, not array-of-utf8
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	tp-glib	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	kai.huuhko
Version:	git master	Keywords:	love
Hardware:	Other
OS:	All
URL:	http://cgit.collabora.com/git/user/wjt/telepathy-glib/commit/?id=5ca4b844209dd4649bc93c485660f569e9ba87f4
Whiteboard:
i915 platform:		i915 features:

Description Will Thompson 2013-01-23 11:40:54 UTC

kuuko on #telepathy discovered that tp_account_update_parameters_vardict_async, when called from python, expects a string (not an array of strings) as its const gchar **unset_parameters argument. Unsurprisingly it then crashes.

11:38         xclaesse | telepathy-glib$ grep "name=\"utf8\" c:type=\"const gchar\*\*\"" TelepathyGLib-0.12.gir  | wc -l
11:38         xclaesse | 14

we should fix 'em all. this untested patch fixes one.

Comment 1 Simon McVittie 2013-01-23 12:15:06 UTC

Patch looks good, grep for further examples also welcome. Also fine for the stable branch(es) since it fixes something that could never have worked before.

Has anyone reported a gobject-introspection bug about this? In principle, I don't think we should have to do this (although it certainly doesn't hurt to do so).

tp_account_update_parameters_vardict_async is probably a relatively easy one to smoke-test with a quick Python script to check that this change is actually necessary and sufficient. README explains how you can use the GIR from an uninstalled telepathy-glib (GI_TYPELIB_PATH=`pwd`/telepathy-glib and export it).

Comment 2 GitLab Migration User 2019-12-03 20:41:13 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-glib/issues/108.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.