| Summary: | module-coreaudio-detect should be default on MacOSX - or merged into modules-detect | ||
|---|---|---|---|
| Product: | PulseAudio | Reporter: | Albert Zeyer <albzey> |
| Component: | misc | Assignee: | pulseaudio-bugs |
| Status: | RESOLVED FIXED | QA Contact: | pulseaudio-bugs |
| Severity: | normal | ||
| Priority: | medium | CC: | adman.com, davec.bugs, lennart, springermac |
| Version: | unspecified | Keywords: | love |
| Hardware: | Other | ||
| OS: | Mac OS X (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
patch for configure.ac
patch for configure patch for default.pa patch for system.pa coreaudiopatch fix missing file |
||
|
Description
Albert Zeyer
2013-04-01 10:54:10 UTC
Yes, module-coreaudio-detect should be loaded by default. I won't fix this myself, so patches welcome. I'll add the "love" keyword so that this bug shows up in the list of "easy" bugs. Created attachment 110104 [details] [review] patch for configure.ac Created attachment 110105 [details] [review] patch for configure Checks for HAVE_COREAUDIO and if set adds it to confdefs.h Created attachment 110106 [details] [review] patch for default.pa Uses modules-coreaudio-detect if HAVE_COREAUDIO is set Created attachment 110107 [details] [review] patch for system.pa Uses modules-coreaudio-detect if HAVE_COREAUDIO is set Added patches to use modules-coreaudio-detect in default.pa and system.pa if CoreAudio is detected during configure Patches pulled from here https://gist.github.com/stephank/1633642 and applied to pulseaudio 5.0 Created attachment 112756 [details] [review] coreaudiopatch Merge patches into one and fix messing with the generated configure by using configure.ac instead. The 1st hunk is missing the file to which it's supposed to apply! Created attachment 113022 [details] [review] fix missing file Comment on attachment 113022 [details] [review] fix missing file Review of attachment 113022 [details] [review]: ----------------------------------------------------------------- This isn't enough yet for me: I find that I still have to disable the loading of module-console-kit and module-systemd-login: --- src/orig.default.pa 2015-01-23 02:45:48.000000000 +0100 +++ src/default.pa 2015-01-23 14:23:05.000000000 +0100 @@ -113,12 +117,12 @@ ### If autoexit on idle is enabled we want to make sure we only quit ### when no local session needs us anymore. -.ifexists module-console-kit.so -load-module module-console-kit -.endif -.ifexists module-systemd-login.so -load-module module-systemd-login -.endif +#.ifexists module-console-kit.so +#load-module module-console-kit +#.endif +#.ifexists module-systemd-login.so +#load-module module-systemd-login +#.endif ### Enable positioned event sounds load-module module-position-event-sounds *** Bug 55154 has been marked as a duplicate of this bug. *** This is fixed in 8.0 (at least the issue with module-coreaudio-detect not being loaded by default - if there are other issues, please file a new bug). |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.