Bug 65126

Summary: withinText="no" does not split the text flow of the parent element
Product: ITS Tool Reporter: Igor Ignatyuk <iignatiouk>
Component: generalAssignee: Shaun McCance <shaunm>
Status: NEW --- QA Contact:
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Input file
Output file

Description Igor Ignatyuk 2013-05-29 12:59:21 UTC
Created attachment 79962 [details]
Input file

An element that is not within text (by default or set explicitly) does not split the text flow of its parent element.

The behavior is the same as if withinText was set to "nested".
Comment 1 Igor Ignatyuk 2013-05-29 13:00:21 UTC
Created attachment 79963 [details]
Output file
Comment 2 Igor Ignatyuk 2013-05-29 13:02:18 UTC
Comment on attachment 79963 [details]
Output file

msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"POT-Creation-Date: 2013-05-29 15:01+0200\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"

#. (itstool) path: head/title
#: in.html:2
msgid "Three text flows"
msgstr ""

#. (itstool) path: div/p
#: in.html:4
msgid "Text flow 2"
msgstr ""

#. (itstool) path: body/div
#: in.html:4
msgid "Text flow 1<_:p-1/>Text flow 3"
msgstr ""
Comment 3 Igor Ignatyuk 2013-05-29 13:04:27 UTC
Comment on attachment 79963 [details]
Output file

msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"POT-Creation-Date: 2013-05-29 15:01+0200\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"

#. (itstool) path: head/title
#: in.html:2
msgid "Three text flows"
msgstr ""

#. (itstool) path: div/p
#: in.html:4
msgid "Text flow 2"
msgstr ""

#. (itstool) path: body/div
#: in.html:4
msgid "Text flow 1<_:p-1/>Text flow 3"
msgstr ""
Comment 4 Igor Ignatyuk 2013-05-29 13:08:18 UTC
Sorry, the attached output file is wrong. The correct content is in the comments on the attachment.
Comment 5 Shaun McCance 2013-05-29 13:48:41 UTC
I see the argument for splitting the text, though we've been using the current behavior with substitution markers for a long time. Splitting the text isn't always the right thing to do. But that's why ITS provides withinText="nested". (Currently there's no difference between "nested" and "no" in itstool.)

It turns out this is non-trivial to do. The example you gave is easy, because there are just three nodes (text, p element, text). But if instead we have this:

<div>Text <span>flow</span> 1<p>Text flow 2</p>Text flow 3</div>

Now we'd have to do a substitution on a group of elements, which will require a significant amount of retooling inside itstool.

This would also be a backwards-incompatible change, so if it happens, it should happen in 2.0.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.