Bug 6623

Summary:

Fix I2C bus Mach64 initialisation failure

Product:

xorg

Reporter:

Samuel Thibault <samuel.thibault>

Component:

Driver/mach64

Assignee:

George - <fufutos610>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

high

CC:

erik.andren, fufutos610, libv

Version:

git

Keywords:

patch

Hardware:

All

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
split ATII2CAddress into ATII2CStart and ATII2CAddress	none

Description Samuel Thibault 2006-04-17 02:42:44 UTC

Hi,

The logs show

(WW) ATI(0): I2C bus Mach64 initialisation failure.
(II) ATI(0): I2C bus "Mach64" removed.

That's because atii2c.c hasn't splitted I2CAddress into I2CStart and I2CAddress. Here is a patch.

Regards,
Samuel

Comment 1 Samuel Thibault 2006-04-17 02:43:13 UTC

Created attachment 5334 [details] [review]
split ATII2CAddress into ATII2CStart and ATII2CAddress

Comment 2 Erik Andren 2006-04-17 18:11:02 UTC

Changing the topic a little bit.

Comment 3 Erik Andren 2006-04-18 04:58:21 UTC

Adjusting topic and add the patch keyword

Comment 4 Luc Verhaegen 2006-04-20 07:17:51 UTC

Will be included in xf86-video-mach64, which is post 7.1 material.

This probably only hurts gatos functionality, as EDID is gathered through VBE.
That will be fixed too in xf86-video-mach64.

Comment 5 George - 2006-04-21 03:42:22 UTC

Hi Samuel,

I'll try your patch and probably try some other stuff over I2C now that it
works. However, I am new to I2C and will appreciate if you elaborate a little
bit on what was wrong, how it is fixed and other stuff you found useful fixing
this. Also, why are you declaring ATII2CStart as:
ATII2CStart(I2CDevPtr pI2CDev)
while xf86i2c.h has the following prototype:
Bool (*I2CStart)  (I2CBusPtr b, int timeout);

thanks,
george.

Comment 6 Samuel Thibault 2006-04-21 04:21:13 UTC

Hi,

I don't know much about i2c in xorg, but it looks like ati's i2c was
not updated to the current convention of I2CStart/I2CAddress/I2CStop
(while the old one probably was only I2CAddress/I2CStop). So I just
split I2CAddress into I2CStart/I2CAddress. I don't have multimedia
devices for actually testing the I2C driver, I mostly submitted the
bug for fixing a warning in my logs :)

The prototype that I set for ATII2CStart is indeed bogus.

Regards,
Samuel

Comment 7 Luc Verhaegen 2006-04-22 07:38:43 UTC

Warning has gone in xf86-video-mach64. Samuel, please switch over to
xf86-video-mach64, you'll get George's EXA to boot.

Comment 8 Samuel Thibault 2006-04-22 21:00:24 UTC

Why not fixing it in xf86-driver-ati too? Some distributions (like debian) don't package xf86-driver-mach64 yet.

Comment 9 Luc Verhaegen 2006-04-23 15:50:22 UTC

xf86-driver-ati is way beyond fixing, but i'm not stopping you from attempting
to do so.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.