Bug 68962

Summary: makeinfo 2.5 deftypevr
Product: GStreamer SDK Reporter: Kyle <zeranoe>
Component: Windows SDK DistributionAssignee: bugs
Status: NEW --- QA Contact:
Severity: critical    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Kyle 2013-09-05 01:50:19 UTC
Nettle has a known bug in version 2.5 that breaks the SDK compile during nettle install.

Here is the output:
make[1]: Entering directory `/home/kyle/cerbero/sources/windows_x86/nettle-2.5'
cd . && makeinfo --output nettle.info `basename "nettle.texinfo"`
nettle.texinfo:738: must be after `@deftypevr' to use `@deftypevrx'
nettle.texinfo:1460: must be after `@deftypevr' to use `@deftypevrx'
make[1]: *** [nettle.info] Error 1

This bug had been talked about before here: http://comments.gmane.org/gmane.comp.encryption.nettle.bugs/459

It was patched shortly after being found with: http://git.lysator.liu.se/nettle/nettle/commit/5ff517e289d186c42f2dc1c462ceb4915582a70c?format=patch

The bug is introduced when a machine has a newer version of makeinfo, this bug was found using version 5.1.

The latest nettle version is currently 2.7.1, updating nettle should resolve this bug.

I would be happy to provide any needed information.
Comment 1 Kyle 2013-09-16 22:29:03 UTC
I patched this locally using:

(https://github.com/Zeranoe/gstreamer-nettle/commit/3ea42852eac94bd7eeae7a5b633e73838337ebcf.patch)

From 3ea42852eac94bd7eeae7a5b633e73838337ebcf Mon Sep 17 00:00:00 2001
From: Kyle Schwarz <zeranoe@gmail.com>
Date: Sun, 15 Sep 2013 15:59:42 -0400
Subject: [PATCH] Fix deftypevr

---
 nettle.texinfo | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/nettle.texinfo b/nettle.texinfo
index 46d4e28..2def4c7 100644
--- a/nettle.texinfo
+++ b/nettle.texinfo
@@ -729,14 +729,14 @@ The last three attributes are function pointers, of types
 @deftypevrx {Constant Struct} {struct nettle_hash} nettle_sha256
 @deftypevrx {Constant Struct} {struct nettle_hash} nettle_sha384
 @deftypevrx {Constant Struct} {struct nettle_hash} nettle_sha512
-
 These are all the hash functions that Nettle implements.
+@end deftypevr
 
-Nettle also exports a list of all these hashes.  This list can be used
-to dynamically enumerate or search the supported algorithms:
-
-@deftypevr {Constant Struct} {struct nettle_hash **} nettle_hashes
+Nettle also exports a list of all these hashes.
 
+@deftypevr {Constant Array} {struct nettle_hash **} nettle_hashes
+This list can be used to dynamically enumerate or search the supported
+algorithms. NULL-terminated.
 @end deftypevr
 
 @node Cipher functions, Cipher modes, Hash functions, Reference
@@ -1449,16 +1449,16 @@ struct, which is of size @code{context_size}.
 @deftypevrx {Constant Struct} {struct nettle_cipher} nettle_twofish128
 @deftypevrx {Constant Struct} {struct nettle_cipher} nettle_twofish192
 @deftypevrx {Constant Struct} {struct nettle_cipher} nettle_twofish256
-
 Nettle includes such structs for all the @emph{regular} ciphers, i.e.
 ones without weak keys or other oddities.
+@end deftypevr
 
 Nettle also exports a list of all these ciphers without weak keys or
-other oddities.  This list can be used to dynamically enumerate or
-search the supported algorithms:
-
-@deftypevrx {Constant Struct} {struct nettle_cipher **} nettle_ciphers
+other oddities.
 
+@deftypevr {Constant Struct} {struct nettle_cipher **} nettle_ciphers
+This list can be used to dynamically enumerate or search the supported
+algorithms. NULL-terminated.
 @end deftypevr
 
 @node Cipher modes, Keyed hash functions, Cipher functions, Reference
-- 
1.8.4

There was an attempted patch that disabled texinfo doc building (http://cgit.freedesktop.org/gstreamer-sdk/nettle/commit/?h=sdk-2.5&id=3b0e2c7cd269ab5a4d2342ef7dc1d8ababbbaea3), but I was still unable to compile after applying those changes.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.