Summary: | Fix some remainging telepathy 1.0 FIXMEs | ||
---|---|---|---|
Product: | Telepathy | Reporter: | Xavier Claessens <xclaesse> |
Component: | tp-glib | Assignee: | Telepathy bugs list <telepathy-bugs> |
Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
Severity: | normal | ||
Priority: | medium | Keywords: | patch |
Version: | git master | ||
Hardware: | Other | ||
OS: | All | ||
URL: | http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=next-misc | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Bug Depends on: | 69431 | ||
Bug Blocks: | 31668 |
Description
Xavier Claessens
2013-09-24 21:12:24 UTC
If they're FIXMEs about 1.0, then our past selves obviously thought it would be a compatibility break to fix them. We should get the initial round of 'next' branches working first, so we have a working state for the whole system. The FIXMEs appear to be * remove tp_account_get_storage_identifier and rename tp_account_dup_storage_identifier_variant to tp_account_dup_storage_identifier (or maybe make it a const "get") * remove tp_account_get_storage_specific_information_async and rename tp_account_dup_storage_specific_information_vardict_async to tp_account_dup_storage_specific_information_async (the FIXME comment wanted it to be a const "get" but I don't know why) * rename tp_connection_manager_dup_protocols to get_protocols (but I think that's been superseded by agreeing that our policy is "if in doubt, (transfer full) and call it _dup") Not rocket surgery. (In reply to comment #3) > http://cgit.collabora.com/git/user/cassidy/telepathy-glib/log/?h=next-misc Indeed, not rocket surgery. Looks fine. Merged |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.