Bug 88970

Summary:	NameOwnerChanged handlers shouldn't assume that the bus is behaving correctly
Product:	PulseAudio	Reporter:	Tanu Kaskinen <tanuk>
Component:	modules	Assignee:	pulseaudio-bugs
Status:	RESOLVED MOVED	QA Contact:	pulseaudio-bugs
Severity:	normal
Priority:	medium	CC:	lennart
Version:	unspecified	Keywords:	love
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Tanu Kaskinen 2015-02-04 16:18:40 UTC

Our policy is that we don't trust any external processes to behave correctly. This means that PulseAudio shouldn't crash or leak memory if some other process does something unexpected.

NameOwnerChanged handlers, at least in bluez5-util and backend-ofono, assume
that the bus daemon is behaving correctly, i.e. that the old name passed via
the signal really is the old name. We should remember the owner name ourselves,
and complain loudly if the bus daemon disagrees about the old name.

Validating the old name is important, because if the bus incorrectly claims that there was no prior owner (the old owner is an empty string), we should clean up our state that we had for the old owner, but currently we don't.

Comment 1 GitLab Migration User 2018-07-30 10:03:44 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/191.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.