Bug 51406

Summary:	doesn't automatically create /var/lib/dbus any more
Product:	dbus	Reporter:	Simon McVittie <smcv>
Component:	core	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	John (J5) Palmieri <johnp>
Severity:	major
Priority:	high	CC:	d, hp
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
Whiteboard:	review+
i915 platform:		i915 features:
Attachments:	Create /var/lib/dbus explicitly rather than as a side-effect

Description Simon McVittie 2012-06-25 05:20:56 UTC

falconindy reported on IRC that dbus-1.6.0 does not automatically create $(DESTDIR)/var/lib/dbus during "make install".

This turns out to be caused by an change in Automake 1.11.4:

 - An empty declaration of a "foo_PRIMARY" don't cause anymore the
   generated install rules to create an empty $(foodir) directory

so our empty localstatelib_DATA is not enough to ensure that localstatelibdir is created.

This will prevent dbus-uuidgen from working. We should create that directory in an install-local hook instead.

Comment 1 Simon McVittie 2012-06-25 05:28:06 UTC

Created attachment 63435 [details] [review]
Create /var/lib/dbus explicitly rather than as a side-effect

Since Automake 1.11.4, an empty localstatelib_DATA variable will not
create $(localstatelibdir) as a side-effect.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=51406
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

Comment 2 Lennart Poettering 2012-06-25 07:04:53 UTC

Looks good to me.

Comment 3 Simon McVittie 2012-07-03 12:13:26 UTC

Fixed in 1.6.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.