Bug 51406 - doesn't automatically create /var/lib/dbus any more
Summary: doesn't automatically create /var/lib/dbus any more
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: unspecified
Hardware: Other All
: high major
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL:
Whiteboard: review+
Keywords: patch
Depends on:
Blocks:
 
Reported: 2012-06-25 05:20 UTC by Simon McVittie
Modified: 2012-07-03 12:13 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:

Attachments
Create /var/lib/dbus explicitly rather than as a side-effect (1.13 KB, patch)
2012-06-25 05:28 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2012-06-25 05:20:56 UTC 
falconindy reported on IRC that dbus-1.6.0 does not automatically create $(DESTDIR)/var/lib/dbus during "make install".

This turns out to be caused by an change in Automake 1.11.4:

 - An empty declaration of a "foo_PRIMARY" don't cause anymore the
   generated install rules to create an empty $(foodir) directory

so our empty localstatelib_DATA is not enough to ensure that localstatelibdir is created.

This will prevent dbus-uuidgen from working. We should create that directory in an install-local hook instead.
Comment 1 Simon McVittie 2012-06-25 05:28:06 UTC 
Created attachment 63435 [details] [review]
Create /var/lib/dbus explicitly rather than as a side-effect

Since Automake 1.11.4, an empty localstatelib_DATA variable will not
create $(localstatelibdir) as a side-effect.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=51406
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Comment 2 Lennart Poettering 2012-06-25 07:04:53 UTC 
Looks good to me.
Comment 3 Simon McVittie 2012-07-03 12:13:26 UTC 
Fixed in 1.6.2

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.