Bug 29174 - implement Protocol, Contacts, Messages etc. in all examples
Summary: implement Protocol, Contacts, Messages etc. in all examples
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: tp-glib (show other bugs)
Version: git master
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: Telepathy bugs list
URL: http://git.collabora.co.uk/?p=user/sm...
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2010-07-20 10:07 UTC by Simon McVittie
Modified: 2010-08-10 08:05 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Simon McVittie 2010-07-20 10:07:43 UTC
All of the telepathy-glib examples ought to use TpBaseProtocol, now that it's ready for merge.

Currently, tests/dbus/protocol-objects assumes that echo does not export protocol objects, but echo-2 (aka echo-message-parts) does.

Since the original Text-only echo CM is no longer exemplary (everyone with Text should ideally implement Messages), I suggest moving it from examples/ into tests/lib/ and re-namespacing accordingly.
Comment 1 Simon McVittie 2010-07-26 08:43:47 UTC
See branch smcv/exemplary for a partial, but reviewable, implementation.

Done:
* echo is no longer an example CM, it's now in tests/lib
* all example CMs implement Contacts
* extended implements Protocol objects
* no-protocols is smaller

To do:
* callable should implement a Protocol object
* call should implement a Protocol object
* channelspecific should implement a Protocol object
* contactlist should implement a Protocol object
Comment 2 Simon McVittie 2010-07-27 07:05:59 UTC
(In reply to comment #1)
> To do:
> * callable should implement a Protocol object
> * call should implement a Protocol object
> * channelspecific should implement a Protocol object
> * contactlist should implement a Protocol object

Done. In addition, channelspecific now uses TpMessageMixin rather than TpTextMixin, and echo2 correctly claims to implement Destroyable.
Comment 3 Guillaume Desmottes 2010-08-10 06:54:53 UTC
+example_extended_protocol_normalize_contact (const gchar *id, GError **error)

should be one line per arg.
Comment 4 Simon McVittie 2010-08-10 08:05:17 UTC
0.11.12


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.