-/* The max length thing is sort of a historical artifact - * from a feature that turned out to be dumb; perhaps - * we should purge it entirely. Less code, fewer bugs!
Created attachment 48285 [details] [review] [PATCH 1/3] Split DBUS_GENERIC_STRING_PREAMBLE into sensible lines
Created attachment 48286 [details] [review] [PATCH 2/3] Remove unused _dbus_string_copy_data_len, _dbus_string_steal_data_len They're only compiled when building tests.
Created attachment 48287 [details] [review] [PATCH 3/3] Remove maximum length field from DBusString The source code says it's "a historical artifact from a feature that turned out to be dumb". Respond accordingly! This reduces sizeof (DBusString) by 20% on ILP32 architectures, which can't hurt. (No reduction on LP64 architectures that align pointers naturally, unfortunately.)
Review of attachment 48285 [details] [review]: Looks fine
Review of attachment 48286 [details] [review]: Seems reasonable.
Review of attachment 48287 [details] [review]: This looks about right to me! I love the idea of a MAX_MAX_LENGTH.
Thanks, fixed in master for 1.5.6.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.