Bug 41012 - remove regression tests that do not actually test anything
Summary: remove regression tests that do not actually test anything
Status: RESOLVED FIXED
Alias: None
Product: dbus
Classification: Unclassified
Component: core (show other bugs)
Version: 1.5
Hardware: Other All
: medium normal
Assignee: Simon McVittie
QA Contact: John (J5) Palmieri
URL: http://cgit.freedesktop.org/~smcv/dbu...
Whiteboard:
Keywords: patch
Depends on:
Blocks: dbus-1.5
  Show dependency tree / graph
 
Reported: 2011-09-19 09:47 UTC by Simon McVittie
Modified: 2011-09-21 04:08 UTC (History)
3 users (show)

See Also:
i915 platform:
i915 features:

Attachments
[1/3] bus_policy_test: remove stub (2.07 KB, patch)
2011-09-19 09:48 UTC, Simon McVittie 		Details | Splinter Review
[2/3] _dbus_marshal_header_test: remove stub (1.86 KB, patch)
2011-09-19 09:48 UTC, Simon McVittie 		Details | Splinter Review
[3/3] _dbus_pending_call_test: remove stub (2.03 KB, patch)
2011-09-19 09:48 UTC, Simon McVittie 		Details | Splinter Review
View All

Description Simon McVittie 2011-09-19 09:47:20 UTC 
Stub test functions offend me. :-)
Comment 1 Simon McVittie 2011-09-19 09:48:05 UTC 
Created attachment 51356 [details] [review]
[1/3] bus_policy_test: remove stub
Comment 2 Simon McVittie 2011-09-19 09:48:25 UTC 
Created attachment 51357 [details] [review]
[2/3] _dbus_marshal_header_test: remove stub
Comment 3 Simon McVittie 2011-09-19 09:48:42 UTC 
Created attachment 51358 [details] [review]
[3/3] _dbus_pending_call_test: remove stub
Comment 4 Will Thompson 2011-09-21 01:27:21 UTC 
Review of attachment 51356 [details] [review]:

++
Comment 5 Will Thompson 2011-09-21 01:27:51 UTC 
Review of attachment 51357 [details] [review]:

++
Comment 6 Will Thompson 2011-09-21 01:29:18 UTC 
Review of attachment 51358 [details] [review]:

++
Comment 7 Simon McVittie 2011-09-21 04:08:13 UTC 
Fixed in git for 1.5.8, thanks

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.