Created attachment 5426 [details] [review]
minor diff

hopefully, this won't break cygwin back

Any chance you can post the build failure from darwin without the patch?  I'd
rather see -no-undefined made mandatory and just fix the required libs as necessary.

(In reply to comment #2)
> Any chance you can post the build failure from darwin without the patch?  I'd
> rather see -no-undefined made mandatory and just fix the required libs as
necessary.

/bin/sh ../libtool --tag=CC --mode=link gcc  -g -O2   -o liblbxutil.la -rpath
/usr/lib -version-number 1:0:0 -no-undefined lbx_zlib_io.lo lbx_zlib.lo
reqstats.lo misc.lo dpackbits.lo epackbits.lo dfaxg42d.lo efaxg42d.lo
lbxdelta.lo  -lz 
gcc -dynamiclib  -o .libs/liblbxutil.1.dylib  .libs/lbx_zlib_io.o
.libs/lbx_zlib.o .libs/reqstats.o .libs/misc.o .libs/dpackbits.o
.libs/epackbits.o .libs/dfaxg42d.o .libs/efaxg42d.o .libs/lbxdelta.o  -lz 
-install_name  /usr/lib/liblbxutil.1.dylib -Wl,-compatibility_version -Wl,2
-Wl,-current_version -Wl,2.0
ld: Undefined symbols:
_Xalloc
_Xfree
/usr/bin/libtool: internal link edit command failed
make[2]: *** [liblbxutil.la] Error 1

i get this error building by hand or using jhbuild
the cygwin patch undid what was done about this exact problem earlier
(http://lists.freedesktop.org/archives/xorg-commit/2005-June/003748.html)

(In reply to comment #3)
> /bin/sh ../libtool --tag=CC --mode=link gcc  -g -O2   -o liblbxutil.la -rpath
> /usr/lib -version-number 1:0:0 -no-undefined lbx_zlib_io.lo lbx_zlib.lo
> reqstats.lo misc.lo dpackbits.lo epackbits.lo dfaxg42d.lo efaxg42d.lo
> lbxdelta.lo  -lz 
> gcc -dynamiclib  -o .libs/liblbxutil.1.dylib  .libs/lbx_zlib_io.o
> .libs/lbx_zlib.o .libs/reqstats.o .libs/misc.o .libs/dpackbits.o
> .libs/epackbits.o .libs/dfaxg42d.o .libs/efaxg42d.o .libs/lbxdelta.o  -lz 
> -install_name  /usr/lib/liblbxutil.1.dylib -Wl,-compatibility_version -Wl,2
> -Wl,-current_version -Wl,2.0
> ld: Undefined symbols:
> _Xalloc
> _Xfree
> /usr/bin/libtool: internal link edit command failed
> make[2]: *** [liblbxutil.la] Error 1
> 
> i get this error building by hand or using jhbuild
> the cygwin patch undid what was done about this exact problem earlier
> (http://lists.freedesktop.org/archives/xorg-commit/2005-June/003748.html)

i'm inclined to fix this by converting lbxutil to just use malloc and free
directly.  i think the ABI makes that safe.  i'll look into this.

being removed for 7.2 anyway