Bug 70962 - Use the right ICE Call capability
Summary: Use the right ICE Call capability
Status: RESOLVED FIXED
Alias: None
Product: Telepathy
Classification: Unclassified
Component: gabble (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Telepathy bugs list
QA Contact: Telepathy bugs list
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-28 15:27 UTC by Guillaume Desmottes
Modified: 2013-10-29 07:24 UTC (History)
0 users

See Also:
i915 platform:
i915 features:

Attachments
[0.18] Use the propre 'Ice' Call capability (5.47 KB, patch)
2013-10-28 15:38 UTC, Guillaume Desmottes 		Details | Splinter Review
View All

Description Guillaume Desmottes 2013-10-28 15:27:44 UTC 
Gabble uses TP_IFACE_CHANNEL_TYPE_CALL1 "/ice-udp" while it's actually just '/ice', see http://telepathy.freedesktop.org/spec/Channel_Type_Call.html#Handler-Capability-Token:ice
Comment 1 Guillaume Desmottes 2013-10-28 15:38:44 UTC 
Created attachment 88235 [details] [review]
[0.18] Use the propre 'Ice' Call capability
Comment 2 Simon McVittie 2013-10-28 19:05:29 UTC 
Comment on attachment 88235 [details] [review]
[0.18] Use the propre 'Ice' Call capability

Review of attachment 88235 [details] [review]:
-----------------------------------------------------------------

"proper"

::: src/media-factory.c
@@ +1227,5 @@
> +          TP_TOKEN_CHANNEL_INTERFACE_MEDIA_SIGNALLING_ICE_UDP);
> +      qc_ice = g_quark_from_static_string (
> +          TP_TOKEN_CHANNEL_TYPE_CALL_ICE);
> +      /* 'ice-dup' isn't the proper cap name, 'ice' is. We keep supporting
> +       * 'ice-dup' for now to not break existing clients. */

'ice-udp'
Comment 3 Guillaume Desmottes 2013-10-29 07:24:36 UTC 
Fixed.

Merged to 0.18 and master.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.