Bug 7235 - AMD64 processors don't have cpuid checked
Summary: AMD64 processors don't have cpuid checked
Status: RESOLVED FIXED
Alias: None
Product: liboil
Classification: Unclassified
Component: unknown (show other bugs)
Version: HEAD
Hardware: x86 (IA32) Linux (All)
: high normal
Assignee: David Schleef
QA Contact: David Schleef
URL:
Whiteboard:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2006-06-15 05:10 UTC by Michael Smith
Modified: 2007-01-01 01:14 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description Michael Smith 2006-06-15 05:10:46 UTC
Right now, at least in CVS head (I haven't checked releases), amd64 never has
the cpuid code called. Trivial patch to get it called:

cvs diff: Diffing liboil
Index: liboil/liboilcpu.c
===================================================================
RCS file: /cvs/liboil/liboil/liboil/liboilcpu.c,v
retrieving revision 1.32
diff -u -r1.32 liboilcpu.c
--- liboil/liboilcpu.c  19 May 2006 06:56:08 -0000      1.32
+++ liboil/liboilcpu.c  15 Jun 2006 12:07:52 -0000
@@ -743,7 +743,7 @@
 static void
 oil_cpu_detect_arch(void)
 {
-#ifdef __i386__
+#if defined(__i386__) || defined(__amd64__)
   oil_cpu_detect_i386();
 #endif
 #if defined(__powerpc__) || defined(__PPC__) || defined(__ppc__)
Comment 1 David Schleef 2007-01-01 01:14:20 UTC
This has been fixed for some time.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.